In Bug 22421 we created accountlines.old_issue_id to hold the issue_id of a finished issue in a way that folllows foreign key constraints. But in boraccount.tt and pay.tt we use issue_id to pull checkout information related to the fee. We need to update those templates to use old_issue_id where it exists. Currently any fee associated with a completed checkout will not show and due date, return date, etc.
Created attachment 177506 [details] [review] Bug 39025: Use old_issue_id for issue details on patron account screens To test: 1: Have an item that is checked out, overdue, and showing an accruing fine 2: On the patron account, check both Make A Payment and Transactions tabs, confirm that the fine shows Due Date, Checkout Date, and Checked Out From values 3: Check your item in 4: Reload the patron account, confirm that the fine no longer shows checkout data on either Make A Payment or Transactions 5: Apply patch 6: Reload pages, confirm Make A Payment and Transactions tabs now show values in Due Date, Checkin Date, Checkout Date, and Checked Out From
Created attachment 177513 [details] [review] Bug 39025: Use old_issue_id for issue details on patron account screens To test: 1: Have an item that is checked out, overdue, and showing an accruing fine 2: On the patron account, check both Make A Payment and Transactions tabs, confirm that the fine shows Due Date, Checkout Date, and Checked Out From values 3: Check your item in 4: Reload the patron account, confirm that the fine no longer shows checkout data on either Make A Payment or Transactions 5: Apply patch 6: Reload pages, confirm Make A Payment and Transactions tabs now show values in Due Date, Checkin Date, Checkout Date, and Checked Out From Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>