Summary: | Fund dropdown not populated for order search on acqui-home | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Pushed to stable --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | normal | ||
Priority: | P5 - low | CC: | emily.lamancusa, nugged, paul.derscheid, tgoatley |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00, 24.11.03
|
Circulation function: | |
Attachments: |
Bug 39044: Pass budgets to template
Bug 39044: Pass budgets to template Bug 39044: Pass budgets to template |
Description
Nick Clemens (kidclamp)
2025-02-05 18:58:07 UTC
Created attachment 177551 [details] [review] Bug 39044: Pass budgets to template This simply copies the fetch of budgets from the acqui/histsearch.pl script. We should in the future make this a template or other method to avoid code duplication, but we should fix the functionality first. To test: 1 - Go to Acqusitions 2 - See the dropdown "Fund: All funds" in the order search section 3 - Click it 4 - Feel disappointed 5 - Apply patch and restart all 6 - Reload and click the dropdown 7 - Options! Feel warm and fuzzy Created attachment 177558 [details] [review] Bug 39044: Pass budgets to template This simply copies the fetch of budgets from the acqui/histsearch.pl script. We should in the future make this a template or other method to avoid code duplication, but we should fix the functionality first. To test: 1 - Go to Acqusitions 2 - See the dropdown "Fund: All funds" in the order search section 3 - Click it 4 - Feel disappointed 5 - Apply patch and restart all 6 - Reload and click the dropdown 7 - Options! Feel warm and fuzzy Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 177640 [details] [review] Bug 39044: Pass budgets to template This simply copies the fetch of budgets from the acqui/histsearch.pl script. We should in the future make this a template or other method to avoid code duplication, but we should fix the functionality first. To test: 1 - Go to Acqusitions 2 - See the dropdown "Fund: All funds" in the order search section 3 - Click it 4 - Feel disappointed 5 - Apply patch and restart all 6 - Reload and click the dropdown 7 - Options! Feel warm and fuzzy Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Pushed for 25.05! Well done everyone, thank you! Can this be backported to 24.11 please! Cheers and thank you! Nice work everyone! Pushed to 24.11.x for 24.11.03 logs full of: [WARN] Use of uninitialized value in repeat (x) at /usr/share/koha/intranet/cgi-bin/acqui/acqui-home.pl line 137. do we have follow-up for this ticket? |