Bug 39044 - Fund dropdown not populated for order search on acqui-home
Summary: Fund dropdown not populated for order search on acqui-home
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-05 18:58 UTC by Nick Clemens (kidclamp)
Modified: 2025-04-28 05:21 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00, 24.11.03
Circulation function:


Attachments
Bug 39044: Pass budgets to template (1.74 KB, patch)
2025-02-05 19:00 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39044: Pass budgets to template (1.79 KB, patch)
2025-02-05 21:36 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39044: Pass budgets to template (1.86 KB, patch)
2025-02-07 16:27 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-02-05 18:58:07 UTC
The new order search form on acqui-home doesn't get the budgets passed in so has a dropdown that cannot be used

To recreate:
1 - Go to Acqusitions
2 - See the dropdown "Fund: All funds" in the order search section
3 - Click it
4 - Feel disappointed
Comment 1 Nick Clemens (kidclamp) 2025-02-05 19:00:26 UTC
Created attachment 177551 [details] [review]
Bug 39044: Pass budgets to template

This simply copies the fetch of budgets from the acqui/histsearch.pl script.

We should in the future make this a template or other method to avoid code duplication,
but we should fix the functionality first.

To test:
1 - Go to Acqusitions
2 - See the dropdown "Fund: All funds" in the order search section
3 - Click it
4 - Feel disappointed
5 - Apply patch and restart all
6 - Reload and click the dropdown
7 - Options! Feel warm and fuzzy
Comment 2 Roman Dolny 2025-02-05 21:36:37 UTC
Created attachment 177558 [details] [review]
Bug 39044: Pass budgets to template

This simply copies the fetch of budgets from the acqui/histsearch.pl script.

We should in the future make this a template or other method to avoid code duplication,
but we should fix the functionality first.

To test:
1 - Go to Acqusitions
2 - See the dropdown "Fund: All funds" in the order search section
3 - Click it
4 - Feel disappointed
5 - Apply patch and restart all
6 - Reload and click the dropdown
7 - Options! Feel warm and fuzzy

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Emily Lamancusa (emlam) 2025-02-07 16:27:31 UTC
Created attachment 177640 [details] [review]
Bug 39044: Pass budgets to template

This simply copies the fetch of budgets from the acqui/histsearch.pl script.

We should in the future make this a template or other method to avoid code duplication,
but we should fix the functionality first.

To test:
1 - Go to Acqusitions
2 - See the dropdown "Fund: All funds" in the order search section
3 - Click it
4 - Feel disappointed
5 - Apply patch and restart all
6 - Reload and click the dropdown
7 - Options! Feel warm and fuzzy

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Katrin Fischer 2025-02-13 14:32:41 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Todd Goatley 2025-03-18 22:07:41 UTC
Can this be backported to 24.11 please! Cheers and thank you!
Comment 6 Paul Derscheid 2025-03-19 23:17:20 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03
Comment 7 Andrii Nugged 2025-04-28 05:21:38 UTC
logs full of:

[WARN] Use of uninitialized value in repeat (x) at /usr/share/koha/intranet/cgi-bin/acqui/acqui-home.pl line 137.

do we have follow-up for this ticket?