Summary: | Add page-section div to reports results pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes several report result pages so that they have a "page-section" div - they now have a white background, instead of the light grey background.
|
Version(s) released in: | |
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Bug 39053: Add page-section div to reports results pages
Bug 39053: Add page-section div to reports results pages Bug 39053: Add page-section div to reports results pages |
Description
Owen Leonard
2025-02-06 14:19:24 UTC
Created attachment 177579 [details] [review] Bug 39053: Add page-section div to reports results pages This patch adds a "page-section" wrapping div around reports results pages where it is missing. Note: This patch contains indentation changes. To test, apply the patch and test the following reports, confirming that the results page looks correct: - Patrons with the most checkouts - Acquisitions statistics - Patrons with no checkouts - Patrons statistics - Most-circulated items - Catalog statistics - Average loan time - Circulation statistics - Lost items - Catalog by item types - Holds statistics Sponsored-by: Athens County Public Libraries Created attachment 177658 [details] [review] Bug 39053: Add page-section div to reports results pages This patch adds a "page-section" wrapping div around reports results pages where it is missing. Note: This patch contains indentation changes. To test, apply the patch and test the following reports, confirming that the results page looks correct: - Patrons with the most checkouts - Acquisitions statistics - Patrons with no checkouts - Patrons statistics - Most-circulated items - Catalog statistics - Average loan time - Circulation statistics - Lost items - Catalog by item types - Holds statistics Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. The database strict mode needs to be turne doff for these reports to work: - Patrons with the most checkouts - Patrons with no checkouts 2. To turn off the database strict mode: - vi /etc/koha/sites/kohadev/koha-conf.xml - Search for strict - Change strict_sql_modes from 1 to 0: <strict_sql_modes>0</strict_sql_modes> - Restart everything: restart_all 3. Add some appropriate data so that the "Lost items" reports is generated: - Edit an item for a record so that it has a lost status of "Lost" - For the report options for Library: change to "All" Created attachment 177943 [details] [review] Bug 39053: Add page-section div to reports results pages This patch adds a "page-section" wrapping div around reports results pages where it is missing. Note: This patch contains indentation changes. To test, apply the patch and test the following reports, confirming that the results page looks correct: - Patrons with the most checkouts - Acquisitions statistics - Patrons with no checkouts - Patrons statistics - Most-circulated items - Catalog statistics - Average loan time - Circulation statistics - Lost items - Catalog by item types - Holds statistics Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> |