Bug 39053 - Add page-section div to reports results pages
Summary: Add page-section div to reports results pages
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2025-02-06 14:19 UTC by Owen Leonard
Modified: 2025-02-12 16:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes several report result pages so that they have a "page-section" div - they now have a white background, instead of the light grey background.
Version(s) released in:
Circulation function:


Attachments
Bug 39053: Add page-section div to reports results pages (34.80 KB, patch)
2025-02-06 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39053: Add page-section div to reports results pages (34.85 KB, patch)
2025-02-08 08:31 UTC, David Nind
Details | Diff | Splinter Review
Bug 39053: Add page-section div to reports results pages (40.12 KB, patch)
2025-02-12 16:37 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-02-06 14:19:24 UTC
Many reports pages lack the <div class="page-section"> wrapper around the table of results.
Comment 1 Owen Leonard 2025-02-06 14:27:33 UTC
Created attachment 177579 [details] [review]
Bug 39053: Add page-section div to reports results pages

This patch adds a "page-section" wrapping div around reports results
pages where it is missing.

Note: This patch contains indentation changes.

To test, apply the patch and test the following reports, confirming that
the results page looks correct:

- Patrons with the most checkouts
- Acquisitions statistics
- Patrons with no checkouts
- Patrons statistics
- Most-circulated items
- Catalog statistics
- Average loan time
- Circulation statistics
- Lost items
- Catalog by item types
- Holds statistics

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-02-08 08:31:38 UTC
Created attachment 177658 [details] [review]
Bug 39053: Add page-section div to reports results pages

This patch adds a "page-section" wrapping div around reports results
pages where it is missing.

Note: This patch contains indentation changes.

To test, apply the patch and test the following reports, confirming that
the results page looks correct:

- Patrons with the most checkouts
- Acquisitions statistics
- Patrons with no checkouts
- Patrons statistics
- Most-circulated items
- Catalog statistics
- Average loan time
- Circulation statistics
- Lost items
- Catalog by item types
- Holds statistics

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-02-08 08:37:20 UTC
Testing notes (using KTD):

1. The database strict mode needs to be turne doff for these reports to work:
   - Patrons with the most checkouts
   - Patrons with no checkouts

2. To turn off the database strict mode:
   - vi /etc/koha/sites/kohadev/koha-conf.xml
   - Search for strict
   - Change strict_sql_modes from 1 to 0: <strict_sql_modes>0</strict_sql_modes>
   - Restart everything: restart_all

3. Add some appropriate data so that the "Lost items" reports is generated:
   - Edit an item for a record so that it has a lost status of "Lost"
   - For the report options for Library: change to "All"
Comment 4 Owen Leonard 2025-02-12 16:37:09 UTC
Created attachment 177943 [details] [review]
Bug 39053: Add page-section div to reports results pages

This patch adds a "page-section" wrapping div around reports results
pages where it is missing.

Note: This patch contains indentation changes.

To test, apply the patch and test the following reports, confirming that
the results page looks correct:

- Patrons with the most checkouts
- Acquisitions statistics
- Patrons with no checkouts
- Patrons statistics
- Most-circulated items
- Catalog statistics
- Average loan time
- Circulation statistics
- Lost items
- Catalog by item types
- Holds statistics

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>