Summary: | Fix DB inconsistencies in the usage statistics module | ||
---|---|---|---|
Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, jonathan.field, katrin.fischer, m.de.rooy, martin.renvoize, matt.blenkinsop, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 34587 | ||
Bug Blocks: | |||
Attachments: |
Bug 39075: Fix DB inconsistencies
Bug 39075: Fix DB inconsistencies Bug 39075: (QA follow-up) Use new bug number. refer to old Bug 39075: Explicit NOT NULL for timestamp |
Description
Matt Blenkinsop
2025-02-10 10:27:06 UTC
Created attachment 177674 [details] [review] Bug 39075: Fix DB inconsistencies This patch fixes DB inconsistencies introduced in bug 34587 Test plan: 1) Run 'updatedatabase' 2) There should be no errors 3) Check the database and observe the correct assignment of the following columns - erm_counter_logs.importdate - erm_counter_files.date_uploaded Created attachment 177727 [details] [review] Bug 39075: Fix DB inconsistencies This patch fixes DB inconsistencies introduced in bug 34587 Test plan: 1) Run 'updatedatabase' 2) There should be no errors 3) Check the database and observe the correct assignment of the following columns - erm_counter_logs.importdate - erm_counter_files.date_uploaded Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] chmod 755 on new dbrev Created attachment 177728 [details] [review] Bug 39075: (QA follow-up) Use new bug number. refer to old Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Thanks Matt. Trivial. SO and QA in one pass. Pushed for 25.05! Well done everyone, thank you! Pondering if this is an enh or a bugfix? https://jenkins.koha-community.org/job/Koha_Main_MariaDB_update/78/console 16:08:12 koha_1 | +++ b/Koha/Schema/Result/ErmCounterFile.pm 16:08:12 koha_1 | @@ -67,7 +67,7 @@ content of the counter file 16:08:12 koha_1 | data_type: 'timestamp' 16:08:12 koha_1 | datetime_undef_if_invalid: 1 16:08:12 koha_1 | default_value: current_timestamp 16:08:12 koha_1 | - is_nullable: 1 16:08:12 koha_1 | + is_nullable: 0 16:08:12 koha_1 | 16:08:12 koha_1 | counter file upload date 16:08:12 koha_1 | 16:08:12 koha_1 | @@ -89,7 +89,7 @@ __PACKAGE__->add_columns( 16:08:12 koha_1 | data_type => "timestamp", 16:08:12 koha_1 | datetime_undef_if_invalid => 1, 16:08:12 koha_1 | default_value => \"current_timestamp", 16:08:12 koha_1 | - is_nullable => 1, 16:08:12 koha_1 | + is_nullable => 0, The db rev is missing the NULL Still valid, we need it for 25.05! Created attachment 181909 [details] [review] Bug 39075: Explicit NOT NULL for timestamp (In reply to Jonathan Druart from comment #9) > Created attachment 181909 [details] [review] [review] > Bug 39075: Explicit NOT NULL for timestamp To fix Koha_Main_MariaDB_update (In reply to Jonathan Druart from comment #9) > Created attachment 181909 [details] [review] [review] > Bug 39075: Explicit NOT NULL for timestamp Patch pushed. |