Highlighted here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587#c38
Created attachment 177674 [details] [review] Bug 39075: Fix DB inconsistencies This patch fixes DB inconsistencies introduced in bug 34587 Test plan: 1) Run 'updatedatabase' 2) There should be no errors 3) Check the database and observe the correct assignment of the following columns - erm_counter_logs.importdate - erm_counter_files.date_uploaded
Created attachment 177727 [details] [review] Bug 39075: Fix DB inconsistencies This patch fixes DB inconsistencies introduced in bug 34587 Test plan: 1) Run 'updatedatabase' 2) There should be no errors 3) Check the database and observe the correct assignment of the following columns - erm_counter_logs.importdate - erm_counter_files.date_uploaded Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] chmod 755 on new dbrev
Created attachment 177728 [details] [review] Bug 39075: (QA follow-up) Use new bug number. refer to old Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thanks Matt. Trivial. SO and QA in one pass.
Pushed for 25.05! Well done everyone, thank you!
Pondering if this is an enh or a bugfix?
https://jenkins.koha-community.org/job/Koha_Main_MariaDB_update/78/console 16:08:12 koha_1 | +++ b/Koha/Schema/Result/ErmCounterFile.pm 16:08:12 koha_1 | @@ -67,7 +67,7 @@ content of the counter file 16:08:12 koha_1 | data_type: 'timestamp' 16:08:12 koha_1 | datetime_undef_if_invalid: 1 16:08:12 koha_1 | default_value: current_timestamp 16:08:12 koha_1 | - is_nullable: 1 16:08:12 koha_1 | + is_nullable: 0 16:08:12 koha_1 | 16:08:12 koha_1 | counter file upload date 16:08:12 koha_1 | 16:08:12 koha_1 | @@ -89,7 +89,7 @@ __PACKAGE__->add_columns( 16:08:12 koha_1 | data_type => "timestamp", 16:08:12 koha_1 | datetime_undef_if_invalid => 1, 16:08:12 koha_1 | default_value => \"current_timestamp", 16:08:12 koha_1 | - is_nullable => 1, 16:08:12 koha_1 | + is_nullable => 0, The db rev is missing the NULL