Summary: | Delivery note in patron notice table is confusing when the delivery method is print | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Notices | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Pushed to main --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | normal | ||
Priority: | P5 - low | CC: | emily.lamancusa, jonathan.druart |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This patch fixes a problem where a patron's email address is shown in the 'Delivery note' column when the message transport type is print.
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 39089: Do not show an email address when the tranport type is print
Bug 39089: Do not show an email address when the tranport type is print Bug 39089: Do not show an email address when the tranport type is print Bug 39089: Do not show an email address when the tranport type is print Bug 39089: (QA follow-up) Apply the same fix to from address and CC address |
Description
Lucas Gass (lukeg)
2025-02-11 00:06:38 UTC
Created attachment 177718 [details] [review] Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. Created attachment 177915 [details] [review] Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. Rebased using the auto-rebase script. Created attachment 179919 [details] [review] Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 180032 [details] [review] Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 180033 [details] [review] Bug 39089: (QA follow-up) Apply the same fix to from address and CC address Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Pushed for 25.05! Well done everyone, thank you! |