Bug 39089 - Delivery note in patron notice table is confusing when the delivery method is print
Summary: Delivery note in patron notice table is confusing when the delivery method is...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-11 00:06 UTC by Lucas Gass (lukeg)
Modified: 2025-02-12 14:03 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch fixes a problem where a patron's email address is shown in the 'Delivery note' column when the message transport type is print.
Version(s) released in:
Circulation function:


Attachments
Bug 39089: Do not show an email address when the tranport type is print (2.10 KB, patch)
2025-02-11 00:12 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39089: Do not show an email address when the tranport type is print (1.97 KB, patch)
2025-02-12 14:03 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-02-11 00:06:38 UTC
To recreate:

1. Set a overdue trigger for print notice
2. Set up an overdue to be captured by overdue_notices.pl 
3. Make sure the patron has an email address
4. Run overdue_notices.pl
5. Run gather_print_notices.pl 
6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x)
7. Find the print row for the overdue just generated.
8. See that under the 'Delivery note' it says "To: test@test.com".

This is confusing to staff as it is a print notice and wasn't delivered to an email address.
Comment 1 Lucas Gass (lukeg) 2025-02-11 00:12:08 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2025-02-12 14:03:24 UTC
Created attachment 177915 [details] [review]
Bug 39089: Do not show an email address when the tranport type is print

To test:
1. Set a overdue trigger for print notice
2. Set up an overdue to be captured by overdue_notices.pl
3. Make sure the patron has an email address
4. Run overdue_notices.pl
5. Run gather_print_notices.pl
6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x)
7. Find the print row for the overdue just generated.
8. See that under the 'Delivery note' it says "To: test@test.com".
9. APPLY PATCH
10. Try again, you should now see no "To:" field when the transport type is print
11. Make sure that when the transport type is anything but print, you do see it.
Comment 3 Jonathan Druart 2025-02-12 14:03:34 UTC
Rebased using the auto-rebase script.