Summary: | Cash registers should have a list API endpoint | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | REST API | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 37893 | ||
Attachments: |
Bug 39091: Add cash registers list REST API endpoint
Bug 39091: Add tests Bug 39091: Add cash registers list REST API endpoint Bug 39091: Add tests Bug 39091: Add cash registers list REST API endpoint Bug 39091: Add tests |
Description
Pedro Amorim
2025-02-11 13:23:52 UTC
Created attachment 177731 [details] [review] Bug 39091: Add cash registers list REST API endpoint Created attachment 177732 [details] [review] Bug 39091: Add tests Test plan: prove t/db_dependent/api/v1/cash_registers.t Created attachment 180253 [details] [review] Bug 39091: Add cash registers list REST API endpoint Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 180254 [details] [review] Bug 39091: Add tests Test plan: prove t/db_dependent/api/v1/cash_registers.t Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Minor QA review point... we're only exposing the 'list' endpoint here.. for that I think we're perhaps being overly cautious on the permissions.. rather than 'manage_cash_registers' which is the 'read,write,delete' permission for registers.. I'd perhaps only require 'catalogue' for the 'staff access' permission for viewing. (In reply to Martin Renvoize (ashimema) from comment #5) > Minor QA review point... we're only exposing the 'list' endpoint here.. for > that I think we're perhaps being overly cautious on the permissions.. rather > than 'manage_cash_registers' which is the 'read,write,delete' permission for > registers.. I'd perhaps only require 'catalogue' for the 'staff access' > permission for viewing. Agree, that would make sense. Also seems not overly sensitive information? Created attachment 180950 [details] [review] Bug 39091: Add cash registers list REST API endpoint Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 180951 [details] [review] Bug 39091: Add tests Test plan: prove t/db_dependent/api/v1/cash_registers.t Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Hi guys, I've squashed the permission change to the main patch and squashed tidyness to tests patch. |