Bug 37893 - Migrate some SIP configuration into the staff interface
Summary: Migrate some SIP configuration into the staff interface
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact: Testopia
URL: https://github.com/PTFS-Europe/koha/c...
Keywords:
Depends on: 37301
Blocks: 37248
  Show dependency treegraph
 
Reported: 2024-09-11 14:27 UTC by Martin Renvoize (ashimema)
Modified: 2024-10-15 09:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
SIPconfig.xml into DB schema (157.52 KB, image/jpeg)
2024-10-08 14:49 UTC, Pedro Amorim
Details
SIPconfig.xml into DB schema (153.73 KB, image/jpeg)
2024-10-10 11:56 UTC, Pedro Amorim
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-09-11 14:27:43 UTC
The 'accounts' and 'institutions' sections of the SIP Server configuration should be able to be moved into the Koha Staff Client.. this would help librarians understand what settings are in place and allow them to make small changes to those configurations as required.
Comment 1 Pedro Amorim 2024-10-08 14:49:46 UTC
Created attachment 172530 [details]
SIPconfig.xml into DB schema

Hi all I've started looking into this.
@Kyle @Nick, can I ask a few minutes of your time to briefly look at this schema before I fully commit to it. I aimed to catch and accommodate all possible configurations values from SIPconfig.xml. Thank you.
Comment 2 Pedro Amorim 2024-10-10 11:56:25 UTC
Created attachment 172584 [details]
SIPconfig.xml into DB schema

sip_institution should be a 1 to 1 with sip_policy, even though SIPconfig.xml technically allows for multiple policies per institution, the template SIPconfig.xml only has one policy per institution and as I understand it the SIP code logic expects only one policy per institution.
This being the case, and policies not relating to anything else, there's no reason to have a separate table for policies specifically and these columns can be merged into sip_institutions instead. Thoughts?
Comment 3 Kyle M Hall (khall) 2024-10-14 11:25:18 UTC
(In reply to Pedro Amorim from comment #2)
> Created attachment 172584 [details]
> SIPconfig.xml into DB schema
> 
> sip_institution should be a 1 to 1 with sip_policy, even though
> SIPconfig.xml technically allows for multiple policies per institution, the
> template SIPconfig.xml only has one policy per institution and as I
> understand it the SIP code logic expects only one policy per institution.
> This being the case, and policies not relating to anything else, there's no
> reason to have a separate table for policies specifically and these columns
> can be merged into sip_institutions instead. Thoughts?

I agree with everything you wrote. I do note the image has institutions and accounts being one to one, but they should be one to many.
Comment 4 Pedro Amorim 2024-10-14 11:51:21 UTC
(In reply to Kyle M Hall (khall) from comment #3)
> I do note the image has institutions and
> accounts being one to one, but they should be one to many.

100%. Tyvm.