|
Description
Juliet Heltibridle
2025-02-11 16:58:50 UTC
I think this is a great idea to improve usability! Created attachment 178284 [details] [review] Bug 39099: Use select2 to select library limitations in item types, patron categories, and authorized values This patch updates some administration templates so that library selection uses a Select2-styled menu instead of a standard <select>. Item types, patron categories, and authorized values all offer a "library limitation" option, and Select2 will make library selection behave like item search options do. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Item types and edit an item type. - On the "Library limitation" line, click the field to trigger the Select2 menu. Confirm that it works as expected. - Save your changes to confirm that the data is saved correctly. - Edit the item type again to clear all your selections and confirm that it saves correctly. - Repeat the same process on the authorized values page and the patron categories page. Sponsored-by: Athens County Public Libraries Created attachment 178480 [details] [review] Bug 39099: Use select2 to select library limitations in item types, patron categories, and authorized values This patch updates some administration templates so that library selection uses a Select2-styled menu instead of a standard <select>. Item types, patron categories, and authorized values all offer a "library limitation" option, and Select2 will make library selection behave like item search options do. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Item types and edit an item type. - On the "Library limitation" line, click the field to trigger the Select2 menu. Confirm that it works as expected. - Save your changes to confirm that the data is saved correctly. - Edit the item type again to clear all your selections and confirm that it saves correctly. - Repeat the same process on the authorized values page and the patron categories page. Sponsored-by: Athens County Public Libraries Signed-off-by: Janne Seppänen <janne.seppanen@lahti.fi> Looks like Bug 26553 got in the way here and a rebase is needed. Created attachment 178727 [details] [review] Bug 39099: Use select2 to select library limitations in item types, patron categories, and authorized values This patch updates some administration templates so that library selection uses a Select2-styled menu instead of a standard <select>. Item types, patron categories, and authorized values all offer a "library limitation" option, and Select2 will make library selection behave like item search options do. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Item types and edit an item type. - On the "Library limitation" line, click the field to trigger the Select2 menu. Confirm that it works as expected. - Save your changes to confirm that the data is saved correctly. - Edit the item type again to clear all your selections and confirm that it saves correctly. - Repeat the same process on the authorized values page and the patron categories page. Sponsored-by: Athens County Public Libraries Signed-off-by: Janne Seppänen <janne.seppanen@lahti.fi> Working on Bug 39810 makes me realize the updated hints in this patch probably don't make sense. I'm thinking something like this would be better: "Limits the use of this authorized value to the selected libraries" I think that makes it more clear given the fact that there isn't an "All libraries" option anymore. Anyone have opinions? Created attachment 181967 [details] Bug 39099: (follow-up) Re-word library limitation hint Created attachment 181976 [details] [review] Bug 39099: (follow-up) Re-word library limitation hint Created attachment 182523 [details] [review] Bug 39099: Use select2 to select library limitations in item types, patron categories, and authorized values This patch updates some administration templates so that library selection uses a Select2-styled menu instead of a standard <select>. Item types, patron categories, and authorized values all offer a "library limitation" option, and Select2 will make library selection behave like item search options do. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Item types and edit an item type. - On the "Library limitation" line, click the field to trigger the Select2 menu. Confirm that it works as expected. - Save your changes to confirm that the data is saved correctly. - Edit the item type again to clear all your selections and confirm that it saves correctly. - Repeat the same process on the authorized values page and the patron categories page. Sponsored-by: Athens County Public Libraries Signed-off-by: Janne Seppänen <janne.seppanen@lahti.fi> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 182524 [details] [review] Bug 39099: (follow-up) Re-word library limitation hint Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Pushed for 25.05! Well done everyone, thank you! Enhancement not pushed to 24.11.x |