Summary: | Clicking the 'Ignore' button on hold found modal for already-waiting hold does not dismiss the modal | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Pushed to stable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, Laura.escamilla, martin.renvoize, paul.derscheid |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00,24.11.03
|
Circulation function: | |
Attachments: |
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal |
Description
Andrew Fuerste-Henry
2025-02-12 14:15:03 UTC
That said, if one clicks "Confirm" the modal goes away without sending a new notice of changing the state of the hold. That makes the Ignore button a little redundant. Created attachment 178484 [details] [review] Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal When ignoring a waiting hold, we don't need to take any further action, we shoudlsimply close the modal This patch adds JS to prevent form submission To test: 1 - place a hold 2 - check in an item that can fill the hold 3 - in the hold found modal, click Ignore 4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) 5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 6 - check in the item again, confirm the modal says "Item is already waiting" 7 - click Ignore, confirm modal reloads 8 - click Ignore, confirm modal reloads 9 - click Ignore, confirm modal reloads 10 - Apply patch 11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 12 - check in the item again, confirm the modal says "Item is already waiting" 13 - click Ignore, nothign happens! Orange you glad I didn't say banana? Created attachment 178609 [details] [review] Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal When ignoring a waiting hold, we don't need to take any further action, we shoudlsimply close the modal This patch adds JS to prevent form submission To test: 1 - place a hold 2 - check in an item that can fill the hold 3 - in the hold found modal, click Ignore 4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) 5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 6 - check in the item again, confirm the modal says "Item is already waiting" 7 - click Ignore, confirm modal reloads 8 - click Ignore, confirm modal reloads 9 - click Ignore, confirm modal reloads 10 - Apply patch 11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 12 - check in the item again, confirm the modal says "Item is already waiting" 13 - click Ignore, nothign happens! Orange you glad I didn't say banana? Signed-off-by: Amanda Campbell <acampbell@hmcpl.org> Created attachment 178693 [details] [review] Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal When ignoring a waiting hold, we don't need to take any further action, we shoudlsimply close the modal This patch adds JS to prevent form submission To test: 1 - place a hold 2 - check in an item that can fill the hold 3 - in the hold found modal, click Ignore 4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) 5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 6 - check in the item again, confirm the modal says "Item is already waiting" 7 - click Ignore, confirm modal reloads 8 - click Ignore, confirm modal reloads 9 - click Ignore, confirm modal reloads 10 - Apply patch 11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting 12 - check in the item again, confirm the modal says "Item is already waiting" 13 - click Ignore, nothign happens! Orange you glad I didn't say banana? Signed-off-by: Amanda Campbell <acampbell@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.03 |