Bug 39171

Summary: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
Product: Koha Reporter: David Gustafsson <glasklas>
Component: Searching - ElasticsearchAssignee: David Gustafsson <glasklas>
Status: Pushed to main --- QA Contact: Thomas Klausner <domm>
Severity: enhancement    
Priority: P5 - low CC: dcook, domm
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on:    
Bug Blocks: 27859    
Attachments: Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
Bug 39171: apply perltidy to atomicupdate file
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
Bug 39171: apply perltidy to atomicupdate file

Description David Gustafsson 2025-02-19 18:02:37 UTC
To better reflect what the actual format is, and avoid using different names in the code and syspref, the ElastcsearchMARCFormat IS02709 should be renamed to  base64ISO2709. Since the setting is actually never explicitly checked anywhere this should be safe to do and very little chance of causing any issues.
Comment 1 David Gustafsson 2025-02-19 18:35:20 UTC
Created attachment 178373 [details] [review]
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709

To test:
1) Apply patch
2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
   pass
Comment 2 David Gustafsson 2025-02-19 18:37:31 UTC
Created attachment 178374 [details] [review]
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709

To test:
1) Apply patch
2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
   pass
Comment 3 David Gustafsson 2025-02-19 18:41:13 UTC
Created attachment 178375 [details] [review]
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709

To test:
1) Apply patch
2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
   pass
Comment 4 David Cook 2025-02-20 00:22:19 UTC
Created attachment 178384 [details] [review]
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709

To test:
1) Apply patch
2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
   pass

Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 David Cook 2025-02-20 00:23:04 UTC
Noting that this isn't passing the QA tools:

 WARN   installer/data/mysql/atomicupdate/bug_39171-rename_IS02709_ElasticsearchMarcFormat_to_base64ISO2709.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0, now: 6)

 OK     installer/data/mysql/mandatory/sysprefs.sql

 OK     t/db_dependent/Koha/SearchEngine/Elasticsearch.t

I'm not sure if atomicupdates are supposed to be tidy or not, so leaving that for a more up-to-date QA person to decide
Comment 6 Thomas Klausner 2025-03-31 08:47:42 UTC
Created attachment 179915 [details] [review]
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709

To test:
1) Apply patch
2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
   pass

Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 7 Thomas Klausner 2025-03-31 08:47:45 UTC
Created attachment 179916 [details] [review]
Bug 39171: apply perltidy to atomicupdate file
Comment 8 Thomas Klausner 2025-03-31 08:52:23 UTC
Created attachment 179917 [details] [review]
Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709

To test:
1) Apply patch
2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
   pass

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Thomas Klausner <domm@plix.at>
Comment 9 Thomas Klausner 2025-03-31 08:52:26 UTC
Created attachment 179918 [details] [review]
Bug 39171: apply perltidy to atomicupdate file

Signed-off-by: Thomas Klausner <domm@plix.at>
Comment 10 Katrin Fischer 2025-04-22 06:43:15 UTC
Thomas, thanks for QA. As we are trying to avoid tidy only patches, I have squashed yours into the main patch. Hope that's OK.

David, please always use say_success for the success messages to keep your RM happy :) Have a look at the database updates for this release.
Comment 11 Katrin Fischer 2025-04-22 06:50:01 UTC
Pushed for 25.05!

Well done everyone, thank you!