To better reflect what the actual format is, and avoid using different names in the code and syspref, the ElastcsearchMARCFormat IS02709 should be renamed to base64ISO2709. Since the setting is actually never explicitly checked anywhere this should be safe to do and very little chance of causing any issues.
Created attachment 178373 [details] [review] Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass
Created attachment 178374 [details] [review] Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass
Created attachment 178375 [details] [review] Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass
Created attachment 178384 [details] [review] Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass Signed-off-by: David Cook <dcook@prosentient.com.au>
Noting that this isn't passing the QA tools: WARN installer/data/mysql/atomicupdate/bug_39171-rename_IS02709_ElasticsearchMarcFormat_to_base64ISO2709.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 6) OK installer/data/mysql/mandatory/sysprefs.sql OK t/db_dependent/Koha/SearchEngine/Elasticsearch.t I'm not sure if atomicupdates are supposed to be tidy or not, so leaving that for a more up-to-date QA person to decide
Created attachment 179915 [details] [review] Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass Signed-off-by: David Cook <dcook@prosentient.com.au>
Created attachment 179916 [details] [review] Bug 39171: apply perltidy to atomicupdate file
Created attachment 179917 [details] [review] Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Thomas Klausner <domm@plix.at>
Created attachment 179918 [details] [review] Bug 39171: apply perltidy to atomicupdate file Signed-off-by: Thomas Klausner <domm@plix.at>
Thomas, thanks for QA. As we are trying to avoid tidy only patches, I have squashed yours into the main patch. Hope that's OK. David, please always use say_success for the success messages to keep your RM happy :) Have a look at the database updates for this release.
Pushed for 25.05! Well done everyone, thank you!