Summary: | Handle and report exception at checkout/checkin due to missing guarantor | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37439 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 12133 | ||
Bug Blocks: | |||
Attachments: | Bug 39180: Catch exception when updating patron lastseen date |
Description
Andrew Fuerste-Henry
2025-02-20 20:17:20 UTC
Created attachment 181941 [details] [review] Bug 39180: Catch exception when updating patron lastseen date This patch adds a catch during checkin and passes a message back to the caller For checkouts and renewals we don't have a method for passing messages so we simply catch the exception and warn - this seems reasonable, I think we should add a warning on the patron display that a required guarantor is missing, but not break circulation. We will need to add unit tests (In reply to Nick Clemens (kidclamp) from comment #1) > Created attachment 181941 [details] [review] [review] > Bug 39180: Catch exception when updating patron lastseen date > > This patch adds a catch during checkin and passes a message back to the > caller > > For checkouts and renewals we don't have a method for passing messages so we > simply catch the exception > and warn - this seems reasonable, I think we should add a warning on the > patron display that a required guarantor > is missing, but not break circulation. > > We will need to add unit tests The general approach here is good, but the popup at checkin should tell the user more specifically what has happened. Something like "This item has been checked-in, but the following warning still needs to be addressed: [Child patron needs a guarantor]." If we put some obvious alert in the patron record, we don't need to give a special message at checkout and renewal. Are you coming back to this one Nick.. it's still marked as NEW.. I like the direction of travel but it sounds like there's a little more to go before NSO? |