Summary: | If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution (again) | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
Component: | Circulation | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Pushed to stable --- | QA Contact: | Lisette Scheer <lisette> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle, lisette, paul.derscheid, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00, 24.11.03
|
Circulation function: | |
Bug Depends on: | 14787 | ||
Bug Blocks: | |||
Attachments: |
Bug 39183: Only check unresolved claims
Bug 39183: Only check unresolved claims Bug 39183: Only check unresolved claims |
Description
Emily Lamancusa (emlam)
2025-02-20 21:52:44 UTC
Created attachment 178538 [details] [review] Bug 39183: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Created attachment 178539 [details] [review] Bug 39183: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> The rebase isn't going any further back, but it did land for 24.11 so this is needed there. Created attachment 178873 [details] [review] Bug 39183: Only check unresolved claims Worked as expected To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Thanks Emily! Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.03 |