Bug 39186

Summary: 'Cancel marked holds' button on patron holds tab styling is inconsistent
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Staff interfaceAssignee: Nick Clemens (kidclamp) <nick>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: gmcharlt, martin.renvoize, phil
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 39186: Update styling of Cancel marked holds button
Bug 39186: Update styling of Cancel marked holds button
Bug 39186: Update styling of Cancel marked holds button

Description Nick Clemens (kidclamp) 2025-02-21 21:47:15 UTC
To recreate:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow

This was a change from 24.05
Comment 1 Nick Clemens (kidclamp) 2025-02-21 21:50:20 UTC
Created attachment 178541 [details] [review]
Bug 39186: Update styling of Cancel marked holds button

This patch adds btn and btn-primary classes

To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow
Comment 2 Phil Ringnalda 2025-02-22 00:47:20 UTC
Created attachment 178542 [details] [review]
Bug 39186: Update styling of Cancel marked holds button

This patch adds btn and btn-primary classes

To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Martin Renvoize (ashimema) 2025-02-26 08:18:19 UTC
Created attachment 178703 [details] [review]
Bug 39186: Update styling of Cancel marked holds button

This patch adds btn and btn-primary classes

To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2025-02-26 12:19:54 UTC
Pushed for 25.05!

Well done everyone, thank you!