Summary: | ESLint doesn't work due bug in old "globals" node package | ||
---|---|---|---|
Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
Component: | Architecture, internals, and plumbing | Assignee: | Victor Grousset/tuxayo <victor> |
Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 38664 | ||
Bug Blocks: | |||
Attachments: |
Bug 39188: Fix ESLint by Updating "globals" node package
Bug 39188: [DO NOT PUSH] yarn.lock [DON'T APPLY IF IT CONFLICTS] |
Description
Victor Grousset/tuxayo
2025-02-24 04:41:07 UTC
Created attachment 178544 [details] [review] Bug 39188: Fix ESLint by Updating "globals" node package According to the main dev of ESLint, we should add it to devDependencies because we are the ones calling globals from eslint.config.mjs: https://github.com/eslint/eslint/issues/19209#issuecomment-2518452107 Test plan: 1. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 2. TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace 3. :( 4. Apply patch 5. sudo yarn install --modules-folder /kohadevbox/node_modules 6. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 7. eslint output a report about the issues found in the file 8. signoff :D Created attachment 178545 [details] [review] Bug 39188: [DO NOT PUSH] yarn.lock [DON'T APPLY IF IT CONFLICTS] |