Summary: | Patron category charge limit inputs should be larger | ||
---|---|---|---|
Product: | Koha | Reporter: | Eric Phetteplace <ephetteplace> |
Component: | Patrons | Assignee: | Eric Phetteplace <ephetteplace> |
Status: | Pushed to main --- | QA Contact: | Lisette Scheer <lisette> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, lisette |
Version: | 24.11 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 39246: Patron category charge limit inputs should be larger
Bug 39246: Patron category charge limit inputs should be larger Bug 39246: Patron category charge limit inputs should be larger |
Description
Eric Phetteplace
2025-03-05 00:13:26 UTC
The class for these inputs is "decimal" but they are an integer field in the database. If you input "50.5", which the decimal class makes it looks like is a valid choice, it is rounded up to "51" in the database which seems like very unexpected behavior. I am going to broaden the scope of this bug rather than create a new one. Never mind, the decimal issue runs deeper, because the $Price on_editing filter makes these integers look like decimals in HTML. The decimal class itself appears to do nothing. I think the fields need to be decimals in the database but that is a more sophisticated change than I am capable of making at the moment so I'm narrowing the scope of the bug again. Created attachment 179005 [details] [review] Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts Created attachment 179149 [details] [review] Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 179350 [details] [review] Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! |