Summary: | Not all settings stick when staging MARC records for import | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Cataloging | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Pushed to stable --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | normal | ||
Priority: | P5 - low | CC: | acampbell, andrew, balestrieri, Chip.Halvorsen, emily.lamancusa, karie.straube, ksheehan, m.de.rooy, paul.derscheid, sam.sowanick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38757 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00,24.11.04
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 39606 | ||
Attachments: |
Bug 39294: Fix includes to properly remember selections
Bug 39294: Fix includes to properly remember selections Bug 39294: Fix includes to properly remember selections Bug 39294: [24.11.x] Fix includes to properly remember selections |
Description
Lucas Gass (lukeg)
2025-03-10 21:55:59 UTC
Created attachment 179131 [details] [review] Bug 39294: Fix includes to properly remember selections To test: 1. Cataloging > Stage MARC record for import 2. Upload a MARC file 3. Change some of the following settings: -Action if matching record found: -Action if no match is found: -How to process items/Item processing: 4. Stage for import and View batch 5. None of this settings have been retained. 6. APPLY PATCH 7. Try these steps again, now the settings should be remembered 8. Turn on the 'MarcOrderingAutomation' system preference. 9. Administration > MARC order accounts 10. Create a new account 11. Change the "Record matching settings" and submit 12. Make sure every selection is remembered when you edit the account. Is this the one that creates such trouble in Acq? (In reply to Katrin Fischer from comment #2) > Is this the one that creates such trouble in Acq? See also Bug 38757 Created attachment 179172 [details] [review] Bug 39294: Fix includes to properly remember selections To test: 1. Cataloging > Stage MARC record for import 2. Upload a MARC file 3. Change some of the following settings: -Action if matching record found: -Action if no match is found: -How to process items/Item processing: 4. Stage for import and View batch 5. None of this settings have been retained. 6. APPLY PATCH 7. Try these steps again, now the settings should be remembered 8. Turn on the 'MarcOrderingAutomation' system preference. 9. Administration > MARC order accounts 10. Create a new account 11. Change the "Record matching settings" and submit 12. Make sure every selection is remembered when you edit the account. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> The patch is still not working. The bug should not be signed off. (In reply to CB from comment #5) > The patch is still not working. The bug should not be signed off. Hmm. All setting selections saved for me after applying this patch. I could have missed something, so can set this back to 'Needs signoff' 'til we know more. Do we have more context on what part of this bug is not working? (In reply to CB from comment #5) > The patch is still not working. The bug should not be signed off. I've spoken to Christie and confirmed this comment was an error. I've also tested this and confirmed it worked. No need to set this back to NSO. I watched Andrew's extremely helpful video about this and the patch works and does what we need it to do! Thank you!! Created attachment 180029 [details] [review] Bug 39294: Fix includes to properly remember selections To test: 1. Cataloging > Stage MARC record for import 2. Upload a MARC file 3. Change some of the following settings: -Action if matching record found: -Action if no match is found: -How to process items/Item processing: 4. Stage for import and View batch 5. None of this settings have been retained. 6. APPLY PATCH 7. Try these steps again, now the settings should be remembered 8. Turn on the 'MarcOrderingAutomation' system preference. 9. Administration > MARC order accounts 10. Create a new account 11. Change the "Record matching settings" and submit 12. Make sure every selection is remembered when you edit the account. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Thanks, Lucas! This all looks good and it fixes the issue. Passing QA Pushed for 25.05! Well done everyone, thank you! Created attachment 181188 [details] [review] Bug 39294: [24.11.x] Fix includes to properly remember selections To test: 1. Cataloging > Stage MARC record for import 2. Upload a MARC file 3. Change some of the following settings: -Action if matching record found: -Action if no match is found: -How to process items/Item processing: 4. Stage for import and View batch 5. None of this settings have been retained. 6. APPLY PATCH 7. Try these steps again, now the settings should be remembered 8. Turn on the 'MarcOrderingAutomation' system preference. 9. Administration > MARC order accounts 10. Create a new account 11. Change the "Record matching settings" and submit 12. Make sure every selection is remembered when you edit the account. Wow cool, thanks for the rebase Lucas :) Nice work everyone! Pushed to 24.11.x for 24.11.04 |