Bug 39294 - Not all settings stick when staging MARC records for import
Summary: Not all settings stick when staging MARC records for import
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords: RM_priority
Depends on:
Blocks:
 
Reported: 2025-03-10 21:55 UTC by Lucas Gass (lukeg)
Modified: 2025-03-31 13:13 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39294: Fix includes to properly remember selections (9.29 KB, patch)
2025-03-10 22:31 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39294: Fix includes to properly remember selections (9.35 KB, patch)
2025-03-11 16:37 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 39294: Fix includes to properly remember selections (9.43 KB, patch)
2025-03-31 13:11 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-03-10 21:55:59 UTC
To recreate:

1. Cataloging > Stage MARC record for import 
2. Upload a MARC file 
3. Change some of the following settings:


-Action if matching record found:
-Action if no match is found:
-How to process items/Item processing:

4. Stage for import and View batch 
5. None of this settings have been retained.
Comment 1 Lucas Gass (lukeg) 2025-03-10 22:31:31 UTC
Created attachment 179131 [details] [review]
Bug 39294: Fix includes to properly remember selections

To test:
1. Cataloging > Stage MARC record for import
2. Upload a MARC file
3. Change some of the following settings:

    -Action if matching record found:
    -Action if no match is found:
    -How to process items/Item processing:

4. Stage for import and View batch
5. None of this settings have been retained.
6. APPLY PATCH
7. Try these steps again, now the settings should be remembered
8. Turn on the 'MarcOrderingAutomation' system preference.
9. Administration > MARC order accounts
10. Create a new account
11. Change the "Record matching settings" and submit
12. Make sure every selection is remembered when you edit the account.
Comment 2 Katrin Fischer 2025-03-11 13:17:10 UTC
Is this the one that creates such trouble in Acq?
Comment 3 Andrew Fuerste-Henry 2025-03-11 15:28:06 UTC
(In reply to Katrin Fischer from comment #2)
> Is this the one that creates such trouble in Acq?

See also Bug 38757
Comment 4 Biblibre Sandboxes 2025-03-11 16:37:48 UTC
Created attachment 179172 [details] [review]
Bug 39294: Fix includes to properly remember selections

To test:
1. Cataloging > Stage MARC record for import
2. Upload a MARC file
3. Change some of the following settings:

    -Action if matching record found:
    -Action if no match is found:
    -How to process items/Item processing:

4. Stage for import and View batch
5. None of this settings have been retained.
6. APPLY PATCH
7. Try these steps again, now the settings should be remembered
8. Turn on the 'MarcOrderingAutomation' system preference.
9. Administration > MARC order accounts
10. Create a new account
11. Change the "Record matching settings" and submit
12. Make sure every selection is remembered when you edit the account.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 5 CB 2025-03-11 16:42:55 UTC
The patch is still not working.  The bug should not be signed off.
Comment 6 SamSowanick 2025-03-11 17:06:10 UTC
(In reply to CB from comment #5)
> The patch is still not working.  The bug should not be signed off.

Hmm. All setting selections saved for me after applying this patch. I could have missed something, so can set this back to 'Needs signoff' 'til we know more.

Do we have more context on what part of this bug is not working?
Comment 7 Andrew Fuerste-Henry 2025-03-11 17:48:00 UTC
(In reply to CB from comment #5)
> The patch is still not working.  The bug should not be signed off.

I've spoken to Christie and confirmed this comment was an error. I've also tested this and confirmed it worked. No need to set this back to NSO.
Comment 8 kate 2025-03-13 23:21:49 UTC
I watched Andrew's extremely helpful video about this and the patch works and does what we need it to do! Thank you!!
Comment 9 Emily Lamancusa (emlam) 2025-03-31 13:11:20 UTC
Created attachment 180029 [details] [review]
Bug 39294: Fix includes to properly remember selections

To test:
1. Cataloging > Stage MARC record for import
2. Upload a MARC file
3. Change some of the following settings:

    -Action if matching record found:
    -Action if no match is found:
    -How to process items/Item processing:

4. Stage for import and View batch
5. None of this settings have been retained.
6. APPLY PATCH
7. Try these steps again, now the settings should be remembered
8. Turn on the 'MarcOrderingAutomation' system preference.
9. Administration > MARC order accounts
10. Create a new account
11. Change the "Record matching settings" and submit
12. Make sure every selection is remembered when you edit the account.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 10 Emily Lamancusa (emlam) 2025-03-31 13:13:58 UTC
Thanks, Lucas! This all looks good and it fixes the issue. Passing QA