Bug 39299

Summary: cn_browser on 952$o fails to open from item editor
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: major    
Priority: P5 - low CC: julian.maurice, m.de.rooy
Version: MainKeywords: RM_priority
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 30975    
Bug Blocks:    
Attachments: Bug 39299: Fix cataloguing plugins in item editor
Bug 39299: Fix cataloguing plugins in serial item editor
Bug 39299: Fix cataloguing plugins in item editor
Bug 39299: Fix cataloguing plugins in serial item editor
Bug 39299: (follow-up) Consistent styling for authorities finder

Description Martin Renvoize (ashimema) 2025-03-11 07:31:49 UTC
Since bug 30975 if you set the cn_browser plugin for 952$o it fails to open in the item editor.
Comment 1 Julian Maurice 2025-03-11 09:21:50 UTC
Created attachment 179146 [details] [review]
Bug 39299: Fix cataloguing plugins in item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the cataloguing module and edit an existing item
3. Click on the tag editor button, the cn_browser.pl popup should appear
Comment 2 Julian Maurice 2025-03-11 09:21:53 UTC
Created attachment 179147 [details] [review]
Bug 39299: Fix cataloguing plugins in serial item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called.

Adding the missing CSS classes caused the tag editor button to be moved
to the left of the input, because of 'float: left' for .tag_editor
It seems that float:left is useless now, at least in cataloguing where
we use 'display: flex' for those elements, so this patch removes it.

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the serial edition page and click on "Add item". This should
   show an item form
3. Click on the tag editor button, the cn_browser.pl popup should appear
Comment 3 Martin Renvoize (ashimema) 2025-03-11 10:12:10 UTC
Created attachment 179152 [details] [review]
Bug 39299: Fix cataloguing plugins in item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the cataloguing module and edit an existing item
3. Click on the tag editor button, the cn_browser.pl popup should appear

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2025-03-11 10:12:12 UTC
Created attachment 179153 [details] [review]
Bug 39299: Fix cataloguing plugins in serial item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called.

Adding the missing CSS classes caused the tag editor button to be moved
to the left of the input, because of 'float: left' for .tag_editor
It seems that float:left is useless now, at least in cataloguing where
we use 'display: flex' for those elements, so this patch removes it.

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the serial edition page and click on "Add item". This should
   show an item form
3. Click on the tag editor button, the cn_browser.pl popup should appear

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2025-03-11 10:12:14 UTC
Created attachment 179154 [details] [review]
Bug 39299: (follow-up) Consistent styling for authorities finder

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2025-03-11 10:13:19 UTC
Clear correction, no regressions found and QA script happy.. going for a straight QA here.
Comment 7 Katrin Fischer 2025-03-13 09:22:29 UTC
Removed the additional space between words here: title="No  popup"
Comment 8 Katrin Fischer 2025-03-13 09:30:22 UTC
Pushed for 25.05!

Well done everyone, thank you!