Summary: | Preserve order when saving patron attributes | ||
---|---|---|---|
Product: | Koha | Reporter: | David Gustafsson <glasklas> |
Component: | Patrons | Assignee: | David Gustafsson <glasklas> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 26744 | ||
Bug Blocks: | 39970 | ||
Attachments: |
Bug 39334: (follow up) Preserve order when adding patron attributes
Bug 39334: (follow-up) Preserve order when adding patron attributes Bug 39334: (follow-up) Preserve order when adding patron attributes |
Description
David Gustafsson
2025-03-14 14:45:14 UTC
Created attachment 179329 [details] [review] Bug 39334: (follow up) Preserve order when adding patron attributes To test: 1) Run tests in t/db_dependent/api/v1/patrons_extended_attributes.t, serveral should fail 2) Apply patch 3) Run the tests in 1) again, all should now pass Hi David, please make sure you are using the newest components (newest ktd, nuke erm_module, yarn install...) - the patch was not tidy. I fixed before pushing and treating this as a follow-up to the original bug Hm, on second thought: since this doesn't fix the tests but changes the code I am asking for a set of QA eyes here too please. Attaching the tidied patch. Created attachment 179377 [details] [review] Bug 39334: (follow-up) Preserve order when adding patron attributes To test: 1) Run tests in t/db_dependent/api/v1/patrons_extended_attributes.t, serveral should fail 2) Apply patch 3) Run the tests in 1) again, all should now pass Created attachment 179388 [details] [review] Bug 39334: (follow-up) Preserve order when adding patron attributes To test: 1) Run tests in t/db_dependent/api/v1/patrons_extended_attributes.t, serveral should fail 2) Apply patch 3) Run the tests in 1) again, all should now pass Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Katrin Fischer from comment #2) > Hi David, please make sure you are using the newest components (newest ktd, > nuke erm_module, yarn install...) - the patch was not tidy. I fixed before > pushing and treating this as a follow-up to the original bug Ok, thanks! Pushed for 25.05! Well done everyone, thank you! |