Bug 39970 - REST API - Creating a patron without mandatory attribute types does not error (it should)
Summary: REST API - Creating a patron without mandatory attribute types does not error...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords: regression
Depends on: 39334
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-22 13:42 UTC by Pedro Amorim
Modified: 2025-06-02 21:27 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 39970: Remove changed_attributes_codes check (4.25 KB, patch)
2025-05-22 13:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 39970: Add tests (1.90 KB, patch)
2025-05-22 13:48 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 39970: Add tests (1.95 KB, patch)
2025-05-22 15:06 UTC, David Nind
Details | Diff | Splinter Review
Bug 39970: Remove changed_attributes_codes check (4.29 KB, patch)
2025-05-22 15:06 UTC, David Nind
Details | Diff | Splinter Review
Bug 39970: Remove changed_attributes_codes check (4.35 KB, patch)
2025-05-27 16:19 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39970: Add tests (2.00 KB, patch)
2025-05-28 12:14 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39970: Remove changed_attributes_codes check (4.35 KB, patch)
2025-05-28 12:14 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-05-22 13:42:50 UTC

    
Comment 1 Pedro Amorim 2025-05-22 13:47:56 UTC
Created attachment 182731 [details] [review]
Bug 39970: Remove changed_attributes_codes check
Comment 2 Pedro Amorim 2025-05-22 13:48:00 UTC
Created attachment 182732 [details] [review]
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t
Comment 3 David Nind 2025-05-22 15:06:21 UTC
Created attachment 182736 [details] [review]
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-05-22 15:06:24 UTC
Created attachment 182737 [details] [review]
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Nick Clemens (kidclamp) 2025-05-27 16:19:39 UTC
Created attachment 182803 [details] [review]
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Nick Clemens (kidclamp) 2025-05-28 12:14:07 UTC
Created attachment 182819 [details] [review]
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2025-05-28 12:14:09 UTC
Created attachment 182820 [details] [review]
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2025-06-02 21:27:54 UTC
Nice work everyone!

Pushed to main for 25.11