| Summary: | move test prediction pattern button | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Serials | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gitbot, jonathan.druart, paola.rossi, paul.poulain, tomascohen |
| Version: | 3.12 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/serials/subscription-add.pl | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 7688 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 3934 - move test prediction pattern button
move test prediction pattern button Bug 3934 - move test prediction pattern button |
||
|
Description
Chris Cormack
2010-05-21 01:21:11 UTC
Created attachment 20484 [details] [review] Bug 3934 - move test prediction pattern button On the subscription add/edit screen the buttons related to numbering patterns are grouped with the "save" button, which is potentially confusing. This patch moves the buttons into the "serials planning" region so they are visually grouped with related functionality. Unrelated changes: Removed a few redundant "javascript:" pseudo-protocols from event handlers, and added a "Cancel" link. To test, edit an existing subscription and confirm that the prediction pattern buttons are grouped inside the "serials planning" region. Confirm that each button triggers the correct event. Confirm that clicking the "cancel" link returns you to the subscription detail view. Also test creating a new subscription. Again buttons should work correctly. The "Cancel" link should return you to the Serials module home page. This template has been completely rewritten by bug 7688 (Passed QA). Maybe it would be wise to wait until it is pushed to master. Patch applied cleanly, go forth and signoff Created attachment 21882 [details] [review] move test prediction pattern button I confirm that the patch works well Note for QAers: Given that bug 7688 is ready for the v.3.14 release, this patch won't be valid. After 7688 has been pushed, I think this one will become irrelevant. Switching to "in discussion", but imo, it could be RESO WONTFIX It could still be a nice enhancement for 3.12 and earlier. Created attachment 22429 [details] [review] Bug 3934 - move test prediction pattern button On the subscription add/edit screen the buttons related to numbering patterns are grouped with the "save" button, which is potentially confusing. This patch moves the buttons into the "serials planning" region so they are visually grouped with related functionality. Unrelated changes: Removed a few redundant "javascript:" pseudo-protocols from event handlers, and added a "Cancel" link. To test, edit an existing subscription and confirm that the prediction pattern buttons are grouped inside the "serials planning" region. Confirm that each button triggers the correct event. Confirm that clicking the "cancel" link returns you to the subscription detail view. Also test creating a new subscription. Again buttons should work correctly. The "Cancel" link should return you to the Serials module home page. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! |