Bug 3934 - move test prediction pattern button
Summary: move test prediction pattern button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.12
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/serials/subscription-ad...
Keywords:
Depends on: 7688
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-16 12:41 UTC by Nicole C. Engard
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 3934 - move test prediction pattern button (4.25 KB, patch)
2013-08-19 16:35 UTC, Owen Leonard
Details | Diff | Splinter Review
move test prediction pattern button (4.26 KB, patch)
2013-10-08 14:41 UTC, Paola Rossi
Details | Diff | Splinter Review
Bug 3934 - move test prediction pattern button (4.31 KB, patch)
2013-10-25 17:03 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:21:11 UTC


---- Reported by nengard@gmail.com 2009-12-16 00:41:48 ----

It would be nice to move the 'test prediction pattern' button up under the prediction box (shouldn't have to scroll to bottom of page)



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 3934 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3934

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Owen Leonard 2013-08-19 16:35:25 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-08-20 08:24:35 UTC
This template has been completely rewritten by bug 7688 (Passed QA).
Maybe it would be wise to wait until it is pushed to master.
Comment 3 I'm just a bot 2013-09-29 05:38:15 UTC
Patch applied cleanly, go forth and signoff
Comment 4 Paola Rossi 2013-10-08 14:41:58 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-10-09 07:50:15 UTC
Note for QAers: Given that bug 7688 is ready for the v.3.14 release, this patch won't be valid.
Comment 6 Paul Poulain 2013-10-21 19:20:16 UTC
After 7688 has been pushed, I think this one will become irrelevant. Switching to "in discussion", but imo, it could be RESO WONTFIX
Comment 7 Katrin Fischer 2013-10-22 01:50:27 UTC
It could still be a nice enhancement for 3.12 and earlier.
Comment 8 Kyle M Hall 2013-10-25 17:03:17 UTC
Created attachment 22429 [details] [review]
Bug 3934 - move test prediction pattern button

On the subscription add/edit screen the buttons related to numbering
patterns are grouped with the "save" button, which is potentially
confusing. This patch moves the buttons into the "serials planning"
region so they are visually grouped with related functionality.

Unrelated changes: Removed a few redundant "javascript:"
pseudo-protocols from event handlers, and added a "Cancel" link.

To test, edit an existing subscription and confirm that the prediction
pattern buttons are grouped inside the "serials planning" region.
Confirm that each button triggers the correct event. Confirm that
clicking the "cancel" link returns you to the subscription detail view.

Also test creating a new subscription. Again buttons should work
correctly. The "Cancel" link should return you to the Serials module
home page.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Tomás Cohen Arazi 2013-12-05 18:29:55 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Owen!