Summary: | Remove unintended Bootstrap 5 change to scroll-behavior | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, dcook, jonathan.druart, lisette |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes two unexpected and unintentional Bootstrap 5 changes:
- It updates the "smooth scroll" behavior introduced in Bootstrap 5 for in-page links. Example: when clicking on a section link for a system administration, the page should jump immediately to that section instead of scrolling.
- It updates some multiple-select dropdown lists used by some system preference controls, where a default option is not selected. When you hovered over the dropdown list, the cursor changed to a "waiting" cursor (rotating circle), this behavour is now removed. Example: the ArticleRequestsMandatoryFields system preference.
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior Bug 39354: (follow-up) Override additional BS5 CSS for multiple-select |
Description
Owen Leonard
2025-03-17 10:23:43 UTC
Created attachment 179383 [details] [review] Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. Created attachment 179415 [details] [review] Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. Signed-off-by: David Nind <david@davidnind.com> Created attachment 179421 [details] [review] Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Better but it still looks like the select2 are disabled IMO. Created attachment 179447 [details] [review] Bug 39354: (follow-up) Override additional BS5 CSS for multiple-select Pushed for 25.05! Well done everyone, thank you! |