| Summary: | Hold found modal does not display from circulation / transfer | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | Pushed to stable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kbecker, kyle, martin.renvoize, nick, paul.derscheid, rcoert, tgoatley |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.05.00,24.11.05
|
|
| Circulation function: | |||
| Bug Depends on: | 25682 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 39361: Wrap modal JS in document ready function
Bug 39361: Wrap modal JS in document ready function Bug 39361: Wrap modal JS in document ready function |
||
|
Description
Lucas Gass (lukeg)
2025-03-17 15:06:30 UTC
It appears like this JavaScript doesn't fire off correctly:
$("#transfer_confirm").modal('show');
I think it needs to be a a '$(document).ready()' function.
Created attachment 179395 [details] [review] Bug 39361: Wrap modal JS in document ready function To test: 1. Find or create an item with a hold on it. 2. Go to Circulation > Transfers 3. Transfer the item from step 1. 4. No modal appears to warn that the item has a hold. 5. APPLY PATCH 6. Try step 3 again, this time the modal should appear correctly. Created attachment 179632 [details] [review] Bug 39361: Wrap modal JS in document ready function To test: 1. Find or create an item with a hold on it. 2. Go to Circulation > Transfers 3. Transfer the item from step 1. 4. No modal appears to warn that the item has a hold. 5. APPLY PATCH 6. Try step 3 again, this time the modal should appear correctly. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial patch, internal SO, moving to QA Created attachment 179799 [details] [review] Bug 39361: Wrap modal JS in document ready function To test: 1. Find or create an item with a hold on it. 2. Go to Circulation > Transfers 3. Transfer the item from step 1. 4. No modal appears to warn that the item has a hold. 5. APPLY PATCH 6. Try step 3 again, this time the modal should appear correctly. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Pushed for 25.05! Well done everyone, thank you! Respectfully requesting that this be backported to 24.11. Thank you! (In reply to Todd Goatley from comment #7) > Respectfully requesting that this be backported to 24.11. > Thank you! Seconding the request to backport to 24.11. Thank you! I third the backport request. Thanks! Nice work everyone! Pushed to 24.11.x for 24.11.05 |