Bug 39361 - Hold found modal does not display from circulation / transfer
Summary: Hold found modal does not display from circulation / transfer
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-17 15:06 UTC by Lucas Gass (lukeg)
Modified: 2025-05-22 18:36 UTC (History)
8 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.05
Circulation function:


Attachments
Bug 39361: Wrap modal JS in document ready function (1.41 KB, patch)
2025-03-17 15:09 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39361: Wrap modal JS in document ready function (1.46 KB, patch)
2025-03-23 16:33 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39361: Wrap modal JS in document ready function (1.53 KB, patch)
2025-03-27 16:55 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-03-17 15:06:30 UTC
To recreate:

1. Find or create an item with a hold on it.
2. Go to Circulation > Transfers
3. Transfer the item from step 1.
4. No modal appears to warn that the item has a hold.
Comment 1 Lucas Gass (lukeg) 2025-03-17 15:07:52 UTC
It appears like this JavaScript doesn't fire off correctly:

$("#transfer_confirm").modal('show');

I think it needs to be a a '$(document).ready()' function.
Comment 2 Lucas Gass (lukeg) 2025-03-17 15:09:30 UTC
Created attachment 179395 [details] [review]
Bug 39361: Wrap modal JS in document ready function

To test:
1. Find or create an item with a hold on it.
2. Go to Circulation > Transfers
3. Transfer the item from step 1.
4. No modal appears to warn that the item has a hold.
5. APPLY PATCH
6. Try step 3 again, this time the modal should appear correctly.
Comment 3 Nick Clemens (kidclamp) 2025-03-23 16:33:54 UTC
Created attachment 179632 [details] [review]
Bug 39361: Wrap modal JS in document ready function

To test:
1. Find or create an item with a hold on it.
2. Go to Circulation > Transfers
3. Transfer the item from step 1.
4. No modal appears to warn that the item has a hold.
5. APPLY PATCH
6. Try step 3 again, this time the modal should appear correctly.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens (kidclamp) 2025-03-23 16:34:16 UTC
Trivial patch, internal SO, moving to QA
Comment 5 Martin Renvoize (ashimema) 2025-03-27 16:55:08 UTC
Created attachment 179799 [details] [review]
Bug 39361: Wrap modal JS in document ready function

To test:
1. Find or create an item with a hold on it.
2. Go to Circulation > Transfers
3. Transfer the item from step 1.
4. No modal appears to warn that the item has a hold.
5. APPLY PATCH
6. Try step 3 again, this time the modal should appear correctly.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 6 Katrin Fischer 2025-04-11 07:56:15 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Todd Goatley 2025-04-15 22:59:11 UTC
Respectfully requesting that this be backported to 24.11. 
Thank you!
Comment 8 Rebecca Coert 2025-05-07 15:03:03 UTC
(In reply to Todd Goatley from comment #7)
> Respectfully requesting that this be backported to 24.11. 
> Thank you!

Seconding the request to backport to 24.11.  Thank you!
Comment 9 Kris 2025-05-15 15:26:48 UTC
I third the backport request. Thanks!
Comment 10 Paul Derscheid 2025-05-22 18:24:51 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.05