Summary: | Warnings from t::lib::Mocks::Zebra because of statement after exec | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 39368: Remove warnings from t::lib::Mocks::Zebra
Bug 39368: Remove warnings from t::lib::Mocks::Zebra Bug 39368: Remove warnings from t::lib::Mocks::Zebra |
Description
Jonathan Druart
2025-03-18 15:20:14 UTC
Created attachment 179454 [details] [review] Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. Created attachment 180086 [details] [review] Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested on top of bug 39367. Patch makes the mentioned tests pass. Created attachment 180238 [details] [review] Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested on top of bug 39367. Patch makes the mentioned tests pass. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Pushed for 25.05! Well done everyone, thank you! |