Bug 39392

Summary: Atomic update README references wrong file extension
Product: Koha Reporter: David Cook <dcook>
Component: Architecture, internals, and plumbingAssignee: David Cook <dcook>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: m.de.rooy, magnus
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 39392: Fix typos in atomicupdate README
Bug 39392: Fix typos in atomicupdate README
Bug 39392: Fix typos in atomicupdate README

Description David Cook 2025-03-20 01:53:48 UTC
installer/data/mysql/atomicupdate/README says:

% cp installer/data/mysql/atomicupdate/skeleton.perl
installer/data/mysql/atomicupdate/bug_XXXXX.perl

But that .perl should be .pl
Comment 1 David Cook 2025-03-20 02:55:26 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2025-03-21 07:53:40 UTC
Not sure about this, but I did a small check with this: 

$ grep -rn "\.perl" *

On C4/Installer.pm, line 876, there is this code:

        if ( $file =~ m{\.perl$} ) {

Not sure if that needs to be changed too?
Comment 3 David Cook 2025-03-23 22:43:52 UTC
(In reply to Magnus Enger from comment #2)
> Not sure about this, but I did a small check with this: 
> 
> $ grep -rn "\.perl" *
> 
> On C4/Installer.pm, line 876, there is this code:
> 
>         if ( $file =~ m{\.perl$} ) {
> 
> Not sure if that needs to be changed too?

It might still be there for historical reasons. It looks like there's different code blocks for for .perl and .pl files in C4/Installer.pm

It might be time to remove it though. Good question...
Comment 4 Magnus Enger 2025-04-02 09:49:39 UTC
Created attachment 180276 [details] [review]
Bug 39392: Fix typos in atomicupdate README

This just fixes some typos in the automicupdate README.
There's nothing to test. Just need to review it.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Makes sense as far as I can tell.
Comment 5 Marcel de Rooy 2025-04-11 08:41:35 UTC
Created attachment 180817 [details] [review]
Bug 39392: Fix typos in atomicupdate README

This just fixes some typos in the automicupdate README.
There's nothing to test. Just need to review it.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Makes sense as far as I can tell.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Katrin Fischer 2025-04-14 06:52:56 UTC
Pushed for 25.05!

Well done everyone, thank you!