installer/data/mysql/atomicupdate/README says: % cp installer/data/mysql/atomicupdate/skeleton.perl installer/data/mysql/atomicupdate/bug_XXXXX.perl But that .perl should be .pl
Created attachment 179496 [details] [review] Bug 39392: Fix typos in atomicupdate README This just fixes some typos in the automicupdate README. There's nothing to test. Just need to review it.
Not sure about this, but I did a small check with this: $ grep -rn "\.perl" * On C4/Installer.pm, line 876, there is this code: if ( $file =~ m{\.perl$} ) { Not sure if that needs to be changed too?
(In reply to Magnus Enger from comment #2) > Not sure about this, but I did a small check with this: > > $ grep -rn "\.perl" * > > On C4/Installer.pm, line 876, there is this code: > > if ( $file =~ m{\.perl$} ) { > > Not sure if that needs to be changed too? It might still be there for historical reasons. It looks like there's different code blocks for for .perl and .pl files in C4/Installer.pm It might be time to remove it though. Good question...
Created attachment 180276 [details] [review] Bug 39392: Fix typos in atomicupdate README This just fixes some typos in the automicupdate README. There's nothing to test. Just need to review it. Signed-off-by: Magnus Enger <magnus@libriotech.no> Makes sense as far as I can tell.
Created attachment 180817 [details] [review] Bug 39392: Fix typos in atomicupdate README This just fixes some typos in the automicupdate README. There's nothing to test. Just need to review it. Signed-off-by: Magnus Enger <magnus@libriotech.no> Makes sense as far as I can tell. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!