Summary: | Self checkout login form not correctly place | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to main --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the self checkout system login page - there was a large vertical gap between the header of the page, and the actual login form.
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 38664 | ||
Bug Blocks: | |||
Attachments: |
Bug 39395: Fix #wrapper closing tag in sco
Bug 39395: Fix #wrapper closing tag in sco Screenshot 1: Self checkout login screen - before the patch Screenshot 2: Self checkout login screen - after the patch Bug 39395: Fix #wrapper closing tag in sco |
Description
Jonathan Druart
2025-03-20 12:48:01 UTC
Created attachment 179516 [details] [review] Bug 39395: Fix #wrapper closing tag in sco The module was displayed at the bottom of the screen. It's caused by the closing tag of #wrapper that has been added by bug 38664 inside the include file. It is wrong, the div.main should be within #wrapper. The correct fix is to move #wrapper out of the include file, so that the HTML structure is correct (and the prettier plugin is happy) in the .tt files Test plan: Confirm the bug Apply this patch Go to the SCO module and confirm that the module is correctly placed at the top of the screen Please review this patch using `git show -w HEAD` Created attachment 179898 [details] [review] Bug 39395: Fix #wrapper closing tag in sco The module was displayed at the bottom of the screen. It's caused by the closing tag of #wrapper that has been added by bug 38664 inside the include file. It is wrong, the div.main should be within #wrapper. The correct fix is to move #wrapper out of the include file, so that the HTML structure is correct (and the prettier plugin is happy) in the .tt files Test plan: Confirm the bug Apply this patch Go to the SCO module and confirm that the module is correctly placed at the top of the screen Please review this patch using `git show -w HEAD` Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. SCO URL: <OPACURL>/cgi-bin/koha/sco/sco-main.pl Created attachment 179899 [details]
Screenshot 1: Self checkout login screen - before the patch
Created attachment 179900 [details]
Screenshot 2: Self checkout login screen - after the patch
I've added some before and after the patch screenshots.
Created attachment 180059 [details] [review] Bug 39395: Fix #wrapper closing tag in sco The module was displayed at the bottom of the screen. It's caused by the closing tag of #wrapper that has been added by bug 38664 inside the include file. It is wrong, the div.main should be within #wrapper. The correct fix is to move #wrapper out of the include file, so that the HTML structure is correct (and the prettier plugin is happy) in the .tt files Test plan: Confirm the bug Apply this patch Go to the SCO module and confirm that the module is correctly placed at the top of the screen Please review this patch using `git show -w HEAD` Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! |