Bug 39395 - Self checkout login form not correctly place
Summary: Self checkout login form not correctly place
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 38664
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-20 12:48 UTC by Jonathan Druart
Modified: 2025-04-10 17:28 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the self checkout system login page - there was a large vertical gap between the header of the page, and the actual login form.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39395: Fix #wrapper closing tag in sco (90.72 KB, patch)
2025-03-20 12:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39395: Fix #wrapper closing tag in sco (90.76 KB, patch)
2025-03-29 09:37 UTC, David Nind
Details | Diff | Splinter Review
Screenshot 1: Self checkout login screen - before the patch (38.51 KB, image/png)
2025-03-29 09:43 UTC, David Nind
Details
Screenshot 2: Self checkout login screen - after the patch (26.21 KB, image/png)
2025-03-29 09:44 UTC, David Nind
Details
Bug 39395: Fix #wrapper closing tag in sco (90.82 KB, patch)
2025-03-31 14:34 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-03-20 12:48:01 UTC
It is at the bottom of the screen.
Comment 1 Jonathan Druart 2025-03-20 12:51:33 UTC
Created attachment 179516 [details] [review]
Bug 39395: Fix #wrapper closing tag in sco

The module was displayed at the bottom of the screen.
It's caused by the closing tag of #wrapper that has been added by bug
38664 inside the include file.

It is wrong, the div.main should be within #wrapper.

The correct fix is to move #wrapper out of the include file, so that the
HTML structure is correct (and the prettier plugin is happy) in the .tt
files

Test plan:
Confirm the bug
Apply this patch
Go to the SCO module and confirm that the module is correctly placed at
the top of the screen

Please review this patch using `git show -w HEAD`
Comment 2 David Nind 2025-03-29 09:37:42 UTC
Created attachment 179898 [details] [review]
Bug 39395: Fix #wrapper closing tag in sco

The module was displayed at the bottom of the screen.
It's caused by the closing tag of #wrapper that has been added by bug
38664 inside the include file.

It is wrong, the div.main should be within #wrapper.

The correct fix is to move #wrapper out of the include file, so that the
HTML structure is correct (and the prettier plugin is happy) in the .tt
files

Test plan:
Confirm the bug
Apply this patch
Go to the SCO module and confirm that the module is correctly placed at
the top of the screen

Please review this patch using `git show -w HEAD`

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-03-29 09:41:10 UTC
Testing notes (using KTD):
1. SCO URL: <OPACURL>/cgi-bin/koha/sco/sco-main.pl
Comment 4 David Nind 2025-03-29 09:43:10 UTC
Created attachment 179899 [details]
Screenshot 1: Self checkout login screen - before the patch
Comment 5 David Nind 2025-03-29 09:44:28 UTC
Created attachment 179900 [details]
Screenshot 2: Self checkout login screen - after the patch

I've added some before and after the patch screenshots.
Comment 6 Lucas Gass (lukeg) 2025-03-31 14:34:31 UTC
Created attachment 180059 [details] [review]
Bug 39395: Fix #wrapper closing tag in sco

The module was displayed at the bottom of the screen.
It's caused by the closing tag of #wrapper that has been added by bug
38664 inside the include file.

It is wrong, the div.main should be within #wrapper.

The correct fix is to move #wrapper out of the include file, so that the
HTML structure is correct (and the prettier plugin is happy) in the .tt
files

Test plan:
Confirm the bug
Apply this patch
Go to the SCO module and confirm that the module is correctly placed at
the top of the screen

Please review this patch using `git show -w HEAD`

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Katrin Fischer 2025-04-10 17:28:02 UTC
Pushed for 25.05!

Well done everyone, thank you!