Summary: | Notice display modal should use shadow dom | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Notices | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | Pushed to main --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, dcook, katrin.fischer, lucas, me, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36780 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 38087, 30287 | ||
Bug Blocks: | 39638 | ||
Attachments: |
Bug 39410: Use shadowDOM for notice display modal
Bug 39410: Use shadowDOM for notice display modal Bug 39410: Use shadowDOM for notice display modal |
Description
Martin Renvoize (ashimema)
2025-03-21 15:15:23 UTC
Created attachment 179626 [details] [review] Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. Created attachment 180065 [details] [review] Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 180274 [details] [review] Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! |