Whilst we improved the notice display modal in bug 30287, it still doesn't fully reflect how a notice appears for the end user. Because we're not using a shadow dom or embedded iframe, we are including all the styles of the parent page within the notice display. (hence it misleads us to think bootstrap styles are available within notices when in fact we do not include the bootstrap sheets in either HTML email or print notice outputs. I propose using shadow dom to rectify that and ensure notice displays match as closely as possible to how they will display to the end user.. be that printed or in their email.
Created attachment 179626 [details] [review] Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug.