Summary: | ILL request status shows empty in OPAC if status_alias used and lib_opac empty | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, pedro.amorim, slavashishkin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 39446: Show both status and status_alias
Bug 39446: Show both status and status_alias |
Description
Pedro Amorim
2025-03-25 13:21:04 UTC
Created attachment 179684 [details] [review] Bug 39446: Show both status and status_alias If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. To test: 1) Enabled ILLModule 2) Create a new ILL request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add '42' on the cardnumber. Pick any library. Click 'Create'. 4) Add a new 'status_alias' entry, visit the authorized values page: http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl 5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. 6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. 7) Visit the previously created ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 8) Click 'Edit request' from the top toolbar. 9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. 10) Visit the ILL on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 11) Notice the 'status' column is empty. Click the 'View', notice the 'status' entry is empty. 12) Apply patch. Repeat Created attachment 180130 [details] [review] Bug 39446: Show both status and status_alias If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. To test: 1) Enabled ILLModule 2) Create a new ILL request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add '42' on the cardnumber. Pick any library. Click 'Create'. 4) Add a new 'status_alias' entry, visit the authorized values page: http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl 5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. 6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. 7) Visit the previously created ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 8) Click 'Edit request' from the top toolbar. 9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. 10) Visit the ILL on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 11) Notice the 'status' column is empty. Click the 'View', notice the 'status' entry is empty. 12) Apply patch. Repeat Signed-off-by: David Nind <david@davidnind.com> I've signed off, as it fixes this for the OPAC. However, the staff interface needs fixing as well. If the "Description" field is left blank, on the staff interface the status shows as "New request test" (test is in bold and italics). |