Bug 39449

Summary: OPAC table sort arrows show opposite sort direction
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: OPACAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to main --- QA Contact: Lisette Scheer <lisette>
Severity: minor    
Priority: P5 - low CC: lisette, martin.renvoize, oleonard, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 39449: Fix table sort arrows
Bug 39449: Fix table sort arrows
Bug 39449: Fix table sort arrows

Description Pedro Amorim 2025-03-25 15:43:23 UTC

    
Comment 1 Pedro Amorim 2025-03-25 15:51:57 UTC
Created attachment 179686 [details] [review]
Bug 39449: Fix table sort arrows

Test plan:
1) Look at the same biblio on both OPAC and Staff:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76

2) Click on the 'current library' column header for OPAC and 'Home library' for staff. Notice that on Staff when it's DESC, arrow points down (as expected), but on OPAC when it's DESC, the arrows points up.

3) Apply patch. Reset CSS:
yarn css:build

4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now behave the same.
Comment 2 Owen Leonard 2025-03-26 11:15:01 UTC
Created attachment 179725 [details] [review]
Bug 39449: Fix table sort arrows

Test plan:
1) Look at the same biblio on both OPAC and Staff:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76

2) Click on the 'current library' column header for OPAC and 'Home
   library' for staff. Notice that on Staff when it's DESC, arrow points
   down (as expected), but on OPAC when it's DESC, the arrows points up.

3) Apply patch. Reset CSS:
   yarn css:build

4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now
   behave the same.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lisette Scheer 2025-03-31 14:30:19 UTC
Created attachment 180055 [details] [review]
Bug 39449: Fix table sort arrows

Test plan:
1) Look at the same biblio on both OPAC and Staff:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76

2) Click on the 'current library' column header for OPAC and 'Home
   library' for staff. Notice that on Staff when it's DESC, arrow points
   down (as expected), but on OPAC when it's DESC, the arrows points up.

3) Apply patch. Reset CSS:
   yarn css:build

4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now
   behave the same.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-04-22 06:50:31 UTC
Pushed for 25.05!

Well done everyone, thank you!