Bug 39449 - OPAC table sort arrows show opposite sort direction
Summary: OPAC table sort arrows show opposite sort direction
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Pedro Amorim
QA Contact: Lisette Scheer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-25 15:43 UTC by Pedro Amorim
Modified: 2025-04-22 06:50 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39449: Fix table sort arrows (2.50 KB, patch)
2025-03-25 15:51 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 39449: Fix table sort arrows (2.57 KB, patch)
2025-03-26 11:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39449: Fix table sort arrows (2.62 KB, patch)
2025-03-31 14:30 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-03-25 15:43:23 UTC

    
Comment 1 Pedro Amorim 2025-03-25 15:51:57 UTC
Created attachment 179686 [details] [review]
Bug 39449: Fix table sort arrows

Test plan:
1) Look at the same biblio on both OPAC and Staff:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76

2) Click on the 'current library' column header for OPAC and 'Home library' for staff. Notice that on Staff when it's DESC, arrow points down (as expected), but on OPAC when it's DESC, the arrows points up.

3) Apply patch. Reset CSS:
yarn css:build

4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now behave the same.
Comment 2 Owen Leonard 2025-03-26 11:15:01 UTC
Created attachment 179725 [details] [review]
Bug 39449: Fix table sort arrows

Test plan:
1) Look at the same biblio on both OPAC and Staff:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76

2) Click on the 'current library' column header for OPAC and 'Home
   library' for staff. Notice that on Staff when it's DESC, arrow points
   down (as expected), but on OPAC when it's DESC, the arrows points up.

3) Apply patch. Reset CSS:
   yarn css:build

4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now
   behave the same.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lisette Scheer 2025-03-31 14:30:19 UTC
Created attachment 180055 [details] [review]
Bug 39449: Fix table sort arrows

Test plan:
1) Look at the same biblio on both OPAC and Staff:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76

2) Click on the 'current library' column header for OPAC and 'Home
   library' for staff. Notice that on Staff when it's DESC, arrow points
   down (as expected), but on OPAC when it's DESC, the arrows points up.

3) Apply patch. Reset CSS:
   yarn css:build

4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now
   behave the same.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-04-22 06:50:31 UTC
Pushed for 25.05!

Well done everyone, thank you!