Summary: | If one basket has uncertain prices, all basket are displayed in red | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | esther.melander, holly, kkrueger, michael.adamyk, nick, sam.sowanick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 39514: Only mark the affected rows as problematic
Bug 39514: Only mark the affected rows as problematic |
Description
Caroline Cyr La Rose
2025-04-01 14:50:53 UTC
Cancelled orders with uncertain prices also cause all baskets for the vendor to display in red. See 36684 Created attachment 187657 [details] [review] Bug 39514: Only mark the affected rows as problematic Before this patch we were setting a variable and nebver unsetting it Now we can add the conditional directly to the row, so don't need a variable To test: 1. Go to Acquisitions 2. Click 'Search' in the vendor search 3. Click 'Add to basket' next to 'My basket' 4. Click 'From a new (empty) record' 5. Fill out the form - Title: enter a title - Koha item type: choose an item type 5.1. Click 'Add item' - Fund: choose a fund - Uncertain price: check 6. Click 'Save' 7. Go back to Acquisitions 8. Click 'Search' in the vendor search 9. Click 'New' > 'Basket' 10. Enter a basket name 11. Click 'Save' 12. Go back to Acquistions 13. Click 'Search' in the vendor search --> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices 14. Click 'Add to basket' --> Notice everything is in bold and some in red 15. Apply patch, reload 16. Only affected basket is in red Created attachment 187662 [details] [review] Bug 39514: Only mark the affected rows as problematic Before this patch we were setting a variable and nebver unsetting it Now we can add the conditional directly to the row, so don't need a variable To test: 1. Go to Acquisitions 2. Click 'Search' in the vendor search 3. Click 'Add to basket' next to 'My basket' 4. Click 'From a new (empty) record' 5. Fill out the form - Title: enter a title - Koha item type: choose an item type 5.1. Click 'Add item' - Fund: choose a fund - Uncertain price: check 6. Click 'Save' 7. Go back to Acquisitions 8. Click 'Search' in the vendor search 9. Click 'New' > 'Basket' 10. Enter a basket name 11. Click 'Save' 12. Go back to Acquistions 13. Click 'Search' in the vendor search --> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices 14. Click 'Add to basket' --> Notice everything is in bold and some in red 15. Apply patch, reload 16. Only affected basket is in red Signed-off-by: Samuel <sam.sowanick@corvallisoregon.com> |