Bug 39530

Summary: Make MARC ordering cronjob respect the AcqCreateItems system preference
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: AcquisitionsAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: Pushed to main --- QA Contact: Nick Clemens (kidclamp) <nick>
Severity: normal    
Priority: P5 - low CC: nick
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 34355    
Bug Blocks:    
Attachments: Bug 39530: Make MARC order cronjob dependent on AcqCreateitems
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems

Description Matt Blenkinsop 2025-04-02 15:20:19 UTC
The value is hardcoded to 'ordering' - this needs to be changed
Comment 1 Matt Blenkinsop 2025-04-03 07:50:55 UTC
Created attachment 180432 [details] [review]
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems

Test plan:
1) View the patch diff and confirm that the hardcoded value of 'ordering' has been replaced with undef
2) In C4/Acquisition.pm, look at the method description for ModBasketHeader and observe the descritpion for 'create_items'
3) Note that if the value is set to undef as per step 1, the AcqCreateItem syspref takes precedence
Comment 2 Nick Clemens (kidclamp) 2025-04-03 08:37:01 UTC
Created attachment 180447 [details] [review]
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems

Test plan:
1) View the patch diff and confirm that the hardcoded value of 'ordering' has been replaced with undef
2) In C4/Acquisition.pm, look at the method description for ModBasketHeader and observe the descritpion for 'create_items'
3) Note that if the value is set to undef as per step 1, the AcqCreateItem syspref takes precedence

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens (kidclamp) 2025-04-03 08:37:53 UTC
Tested using test plan from 39518 andd verified create_items setting in the new basket - trivial patch, PQA
Comment 4 Katrin Fischer 2025-04-25 06:49:22 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Katrin Fischer 2025-04-25 14:20:20 UTC
Sounds like a bug? :)