Bug 39550

Summary: RestrictPatronsWithFailedNotices system preference should not be in patron relationships section
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: System AdministrationAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: aude.charillon, chris, fridolin.somers, gmcharlt, paivi.knuutinen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This moves the system preference `RestrictPatronsWithFailedNotices' into the right section of the system preferences editor.
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 23295    
Bug Blocks:    
Attachments: Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section
Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section

Description Caroline Cyr La Rose 2025-04-03 15:05:19 UTC
I was going to document bug 23295, and noticed the new system preference is under the Patron relationships section. I feel like that's not the right place for it. But there doesn't seem to be a fitting section for it either. Here are some options I thought about

1. Create a "Patron restrictions" section
- either with only this one, or we could move a couple of other ones too like useDischarge

2. Place the pref under "General"

2. Place under "Notices and notifications"
Comment 1 Caroline Cyr La Rose 2025-04-04 07:27:07 UTC
> 2. Place under "Notices and notifications"

Was supposed to be 3. ;)
Comment 2 Chris Cormack 2025-04-04 07:39:08 UTC
Option 1 makes sense to me.
Comment 3 Caroline Cyr La Rose 2025-04-04 08:19:14 UTC
Created attachment 180614 [details] [review]
Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section

This patch changes the RestrictPatronsWithFailedNotices system
preference from the Patron relationships subsection of the Patron
preferences to a newly created Patron restrictions subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > Patrons
--> There should be a new section called 'Patron restrictions'
with RestrictPatronsWithFailedNotices in it
Comment 4 David Nind 2025-04-04 09:39:27 UTC
Created attachment 180622 [details] [review]
Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section

This patch changes the RestrictPatronsWithFailedNotices system
preference from the Patron relationships subsection of the Patron
preferences to a newly created Patron restrictions subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > Patrons
--> There should be a new section called 'Patron restrictions'
with RestrictPatronsWithFailedNotices in it

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Päivi Knuutinen 2025-04-04 10:23:55 UTC
It works as planned.
Comment 6 Katrin Fischer 2025-05-06 17:40:46 UTC
Don't forget to set assignee :)
Comment 7 Caroline Cyr La Rose 2025-05-06 18:03:42 UTC
(In reply to Katrin Fischer from comment #6)
> Don't forget to set assignee :)

Sorry, I think I will always forget!
Comment 8 Katrin Fischer 2025-05-07 12:31:30 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 9 Aude Charillon 2025-07-23 13:32:39 UTC
Suggestions for the future follow-up bug: move CumulativeRestrictionPeriods and PatronRestrictionTypes out of Circulation > Patron restrictions to the new Patrons > Patron restrictions section.

Maybe get rid of Circulation > Patron restrictions altogether by moving the remaining two system preferences to the Checkin policy / Checkout policy sections?
Comment 10 Fridolin Somers 2025-08-06 13:04:45 UTC
Enhancement not pushed to 24.11.x
Comment 11 Aude Charillon 2025-08-06 13:16:08 UTC
When documenting bug 23295, I added the RestrictPatronsWithFailedNotices system preference to the new Patron restrictions subsection. It's a small enough change between versions 24.11 and 25.05 that I don't think the Manual needs a note.

Do re-open this bug if you think differently.