I was going to document bug 23295, and noticed the new system preference is under the Patron relationships section. I feel like that's not the right place for it. But there doesn't seem to be a fitting section for it either. Here are some options I thought about 1. Create a "Patron restrictions" section - either with only this one, or we could move a couple of other ones too like useDischarge 2. Place the pref under "General" 2. Place under "Notices and notifications"
> 2. Place under "Notices and notifications" Was supposed to be 3. ;)
Option 1 makes sense to me.
Created attachment 180614 [details] [review] Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section This patch changes the RestrictPatronsWithFailedNotices system preference from the Patron relationships subsection of the Patron preferences to a newly created Patron restrictions subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > Patrons --> There should be a new section called 'Patron restrictions' with RestrictPatronsWithFailedNotices in it
Created attachment 180622 [details] [review] Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section This patch changes the RestrictPatronsWithFailedNotices system preference from the Patron relationships subsection of the Patron preferences to a newly created Patron restrictions subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > Patrons --> There should be a new section called 'Patron restrictions' with RestrictPatronsWithFailedNotices in it Signed-off-by: David Nind <david@davidnind.com>
It works as planned.
Don't forget to set assignee :)
(In reply to Katrin Fischer from comment #6) > Don't forget to set assignee :) Sorry, I think I will always forget!
Pushed for 25.05! Well done everyone, thank you!
Suggestions for the future follow-up bug: move CumulativeRestrictionPeriods and PatronRestrictionTypes out of Circulation > Patron restrictions to the new Patrons > Patron restrictions section. Maybe get rid of Circulation > Patron restrictions altogether by moving the remaining two system preferences to the Checkin policy / Checkout policy sections?
Enhancement not pushed to 24.11.x
When documenting bug 23295, I added the RestrictPatronsWithFailedNotices system preference to the new Patron restrictions subsection. It's a small enough change between versions 24.11 and 25.05 that I don't think the Manual needs a note. Do re-open this bug if you think differently.