Bug 39550 - RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section
Summary: RestrictPatronsWithFailedNotices system preference should not be in Patron re...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Caroline Cyr La Rose
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 23295
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-03 15:05 UTC by Caroline Cyr La Rose
Modified: 2025-05-07 12:31 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section (1.36 KB, patch)
2025-04-04 08:19 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section (1.41 KB, patch)
2025-04-04 09:39 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2025-04-03 15:05:19 UTC
I was going to document bug 23295, and noticed the new system preference is under the Patron relationships section. I feel like that's not the right place for it. But there doesn't seem to be a fitting section for it either. Here are some options I thought about

1. Create a "Patron restrictions" section
- either with only this one, or we could move a couple of other ones too like useDischarge

2. Place the pref under "General"

2. Place under "Notices and notifications"
Comment 1 Caroline Cyr La Rose 2025-04-04 07:27:07 UTC
> 2. Place under "Notices and notifications"

Was supposed to be 3. ;)
Comment 2 Chris Cormack 2025-04-04 07:39:08 UTC
Option 1 makes sense to me.
Comment 3 Caroline Cyr La Rose 2025-04-04 08:19:14 UTC
Created attachment 180614 [details] [review]
Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section

This patch changes the RestrictPatronsWithFailedNotices system
preference from the Patron relationships subsection of the Patron
preferences to a newly created Patron restrictions subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > Patrons
--> There should be a new section called 'Patron restrictions'
with RestrictPatronsWithFailedNotices in it
Comment 4 David Nind 2025-04-04 09:39:27 UTC
Created attachment 180622 [details] [review]
Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section

This patch changes the RestrictPatronsWithFailedNotices system
preference from the Patron relationships subsection of the Patron
preferences to a newly created Patron restrictions subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > Patrons
--> There should be a new section called 'Patron restrictions'
with RestrictPatronsWithFailedNotices in it

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Päivi Knuutinen 2025-04-04 10:23:55 UTC
It works as planned.
Comment 6 Katrin Fischer 2025-05-06 17:40:46 UTC
Don't forget to set assignee :)
Comment 7 Caroline Cyr La Rose 2025-05-06 18:03:42 UTC
(In reply to Katrin Fischer from comment #6)
> Don't forget to set assignee :)

Sorry, I think I will always forget!
Comment 8 Katrin Fischer 2025-05-07 12:31:30 UTC
Pushed for 25.05!

Well done everyone, thank you!