Summary: | Create EDIFACT order button no longer gives librarians chance to review | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Acquisitions | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Signed Off --- | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, emily.lamancusa, jeremy.evans, lucas, martin.renvoize, sam.sowanick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the EDIFACT order confirmation message for a basket so that the EAN information is now included on the confirmation page ([a basket for a vendor] > Create EDIFACT order > [select EAN from dropdown list], with the BasketConfirmations system preference set to 'always ask for conformation').
Previously, the `Create EDIFACT order` action would take librarians to a page to select the EDI Library EAN. Now, the EANs are included in a dropdown list for the action. This removed the chance to review the selected EAN to confirm it was correct. In addition, some libraries have dozens of Library EANs, making the button dropdown list cumbersome to use.
|
|
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 39572: Improve EDIFACT order confirmation message
Bug 39572: Improve EDIFACT order confirmation message Bug 39572: Improve EDIFACT order confirmation message |
Description
Kyle M Hall (khall)
2025-04-07 14:18:32 UTC
+1, Our acquisitions person would greatly appreciate having the secondary confirmation screen when selecting EAN account. Ideally it should show by default the supplier who sent the original EDI quote for that basket into Koha. That would reduce the possibility of user error of sending the confirmed order to the wrong supplier. At the moment it shows the first supplier sorted alphabetically by default. Limiting to the vendor sounds like a good idea. Even still, we have several accounts per vendor and accidently sending via the wrong account is still not ideal. Could it also be possible to have the best of both worlds, by splitting the button? One that takes you to a separate page as it was before, and the arrow-dropdown portion of the button provides the accounts as it is now. Like the "Export as CSV" button to its left. Maybe that is needlessly complicated; just a thought. -- Another possibility could be a popup confirmation with the opportunity to cancel the selection, without going to a new page. Created attachment 183501 [details] [review] Bug 39572: Improve EDIFACT order confirmation message Add EAN account information to EDIFACT order confirmation message To test: 1. Set EDIFACT system preference to Enable 2. Create at least 2 EANs, one with a description and one without a description i. Go to Acquisitions > Library EANs ii. Click "New EAN" and fill in the fields 3. Create an EDI account i. Go to Acquisitions > EDI accounts ii. Click "New account" iii. Click Submit (for testing purposes you don't need to fill in the fields) 4. Find or create a basket for the same vendor that's on the EDI account 5. Add an order to the basket from any source 6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close" 8. Apply patch and restart_all 9. Repeat step 6 --> The confirmation page should now display both the basket and the selected EAN 10. Click "Cancel" --> Confirm that the basket is still open 11. Repeat step 6 12. Click "Yes, generate order and close basket" --> Confirm the basket is closed 13. Click "EDIFACT messages" in the sidebar menu --> Confirm that you see a message with type ORDERS for that basket (In reply to Emily Lamancusa (emlam) from comment #4) > 6. In the menu bar at the top of the basket screen, click "Create > EDIFACT order" and select an EAN > --> Note that the confirmation page doesn't tell you which EAN was > selected > 7. Click "No, don't close" I don't see a confirmation page when trying to reproduce this bug. Am I missing a setting somewhere? (In reply to Owen Leonard from comment #5) > (In reply to Emily Lamancusa (emlam) from comment #4) > > > 6. In the menu bar at the top of the basket screen, click "Create > > EDIFACT order" and select an EAN > > --> Note that the confirmation page doesn't tell you which EAN was > > selected > > 7. Click "No, don't close" > > I don't see a confirmation page when trying to reproduce this bug. Am I > missing a setting somewhere? I think there might not be a confirmation page if you only have one EAN created? (I didn't specifically test with only one EAN, so I'm not 100% sure) Could that be it? If not, I'll try starting over with a fresh KTD and see if I changed something that I forgot to include in the test plan. P.S. Thank you for testing! Aha! It's probably the BasketConfirmations system preference - it needs to be set to "always ask for confirmation". Created attachment 183632 [details] [review] Bug 39572: Improve EDIFACT order confirmation message Add EAN account information to EDIFACT order confirmation message To test: 1. Set EDIFACT system preference to Enable 2. Create at least 2 EANs, one with a description and one without a description i. Go to Acquisitions > Library EANs ii. Click "New EAN" and fill in the fields 3. Create an EDI account i. Go to Acquisitions > EDI accounts ii. Click "New account" iii. Click Submit (for testing purposes you don't need to fill in the fields) 4. Find or create a basket for the same vendor that's on the EDI account 5. Add an order to the basket from any source 6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close" 8. Apply patch and restart_all 9. Repeat step 6 --> The confirmation page should now display both the basket and the selected EAN 10. Click "Cancel" --> Confirm that the basket is still open 11. Repeat step 6 12. Click "Yes, generate order and close basket" --> Confirm the basket is closed 13. Click "EDIFACT messages" in the sidebar menu --> Confirm that you see a message with type ORDERS for that basket Signed-off-by: David Nind <david@davidnind.com> Created attachment 183675 [details] [review] Bug 39572: Improve EDIFACT order confirmation message Add EAN account information to EDIFACT order confirmation message To test: 1. Set EDIFACT system preference to Enable 2. Create at least 2 EANs, one with a description and one without a description i. Go to Acquisitions > Library EANs ii. Click "New EAN" and fill in the fields 3. Create an EDI account i. Go to Acquisitions > EDI accounts ii. Click "New account" iii. Click Submit (for testing purposes you don't need to fill in the fields) 4. Find or create a basket for the same vendor that's on the EDI account 5. Add an order to the basket from any source 6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close" 8. Apply patch and restart_all 9. Repeat step 6 --> The confirmation page should now display both the basket and the selected EAN 10. Click "Cancel" --> Confirm that the basket is still open 11. Repeat step 6 12. Click "Yes, generate order and close basket" --> Confirm the basket is closed 13. Click "EDIFACT messages" in the sidebar menu --> Confirm that you see a message with type ORDERS for that basket Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |