Bug 39572 - Create EDIFACT order button no longer forces librarians to review EAN to select
Summary: Create EDIFACT order button no longer forces librarians to review EAN to select
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Emily Lamancusa (emlam)
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on: 37993
Blocks: 40587
  Show dependency treegraph
 
Reported: 2025-04-07 14:18 UTC by Kyle M Hall (khall)
Modified: 2025-08-04 12:17 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the EDIFACT order confirmation message for a basket so that the EAN information is now included on the confirmation page ([a basket for a vendor] > Create EDIFACT order > [select EAN from dropdown list], with the BasketConfirmations system preference set to 'always ask for conformation'). Previously, the `Create EDIFACT order` action would take librarians to a page to select the EDI Library EAN. Now, the EANs are included in a dropdown list for the action. This removed the chance to review the selected EAN to confirm it was correct. In addition, some libraries have dozens of Library EANs, making the button dropdown list cumbersome to use.
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:


Attachments
Bug 39572: Improve EDIFACT order confirmation message (5.75 KB, patch)
2025-06-25 14:35 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 39572: Improve EDIFACT order confirmation message (5.80 KB, patch)
2025-06-27 20:03 UTC, David Nind
Details | Diff | Splinter Review
Bug 39572: Improve EDIFACT order confirmation message (5.87 KB, patch)
2025-07-01 16:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 39572: Improve EDIFACT order confirmation message (6.03 KB, patch)
2025-07-08 16:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2025-04-07 14:18:32 UTC
Previously, the Create EDIFACT order button would take librarians to a page to select the correct EDI Library EAN. Now those EANs are listed on the button when clicked.

The problem is this removes the chance to review the selection. There is no chance to review the selected EAN to confirm is was chosen correctly. In addition, some libraries have dozens of Library EANs making the button pulldown cumbersome to use.
Comment 1 SamSowanick 2025-04-30 21:37:01 UTC
+1, Our acquisitions person would greatly appreciate having the secondary confirmation screen when selecting EAN account.
Comment 2 Jeremy Evans 2025-05-01 14:01:32 UTC
Ideally it should show by default the supplier who sent the original EDI quote for that basket into Koha. That would reduce the possibility of user error of sending the confirmed order to the wrong supplier. At the moment it shows the first supplier sorted alphabetically by default.
Comment 3 SamSowanick 2025-05-01 16:09:06 UTC
Limiting to the vendor sounds like a good idea. Even still, we have several accounts per vendor and accidently sending via the wrong account is still not ideal.

Could it also be possible to have the best of both worlds, by splitting the button? One that takes you to a separate page as it was before, and the arrow-dropdown portion of the button provides the accounts as it is now. Like the "Export as CSV" button to its left.

Maybe that is needlessly complicated; just a thought.

--

Another possibility could be a popup confirmation with the opportunity to cancel the selection, without going to a new page.
Comment 4 Emily Lamancusa (emlam) 2025-06-25 14:35:50 UTC
Created attachment 183501 [details] [review]
Bug 39572: Improve EDIFACT order confirmation message

Add EAN account information to EDIFACT order confirmation message

To test:
1. Set EDIFACT system preference to Enable
2. Create at least 2 EANs, one with a description and one without a
   description
   i. Go to Acquisitions > Library EANs
   ii. Click "New EAN" and fill in the fields
3. Create an EDI account
   i. Go to Acquisitions > EDI accounts
   ii. Click "New account"
   iii. Click Submit (for testing purposes you don't need to fill in
         the fields)
4. Find or create a basket for the same vendor that's on the EDI account
5. Add an order to the basket from any source
6. In the menu bar at the top of the basket screen, click "Create
   EDIFACT order" and select an EAN
--> Note that the confirmation page doesn't tell you which EAN was
    selected
7. Click "No, don't close"
8. Apply patch and restart_all
9. Repeat step 6
--> The confirmation page should now display both the basket and the
    selected EAN
10. Click "Cancel"
--> Confirm that the basket is still open
11. Repeat step 6
12. Click "Yes, generate order and close basket"
--> Confirm the basket is closed
13. Click "EDIFACT messages" in the sidebar menu
--> Confirm that you see a message with type ORDERS for that basket
Comment 5 Owen Leonard 2025-06-26 14:29:19 UTC
(In reply to Emily Lamancusa (emlam) from comment #4)

> 6. In the menu bar at the top of the basket screen, click "Create
>    EDIFACT order" and select an EAN
> --> Note that the confirmation page doesn't tell you which EAN was
>     selected
> 7. Click "No, don't close"

I don't see a confirmation page when trying to reproduce this bug. Am I missing a setting somewhere?
Comment 6 Emily Lamancusa (emlam) 2025-06-26 15:01:34 UTC
(In reply to Owen Leonard from comment #5)
> (In reply to Emily Lamancusa (emlam) from comment #4)
> 
> > 6. In the menu bar at the top of the basket screen, click "Create
> >    EDIFACT order" and select an EAN
> > --> Note that the confirmation page doesn't tell you which EAN was
> >     selected
> > 7. Click "No, don't close"
> 
> I don't see a confirmation page when trying to reproduce this bug. Am I
> missing a setting somewhere?

I think there might not be a confirmation page if you only have one EAN created? (I didn't specifically test with only one EAN, so I'm not 100% sure) Could that be it?

If not, I'll try starting over with a fresh KTD and see if I changed something that I forgot to include in the test plan.
Comment 7 Emily Lamancusa (emlam) 2025-06-26 15:01:55 UTC
P.S. Thank you for testing!
Comment 8 Emily Lamancusa (emlam) 2025-06-27 13:28:08 UTC
Aha! It's probably the BasketConfirmations system preference - it needs to be set to "always ask for confirmation".
Comment 9 David Nind 2025-06-27 20:03:37 UTC
Created attachment 183632 [details] [review]
Bug 39572: Improve EDIFACT order confirmation message

Add EAN account information to EDIFACT order confirmation message

To test:
1. Set EDIFACT system preference to Enable
2. Create at least 2 EANs, one with a description and one without a
   description
   i. Go to Acquisitions > Library EANs
   ii. Click "New EAN" and fill in the fields
3. Create an EDI account
   i. Go to Acquisitions > EDI accounts
   ii. Click "New account"
   iii. Click Submit (for testing purposes you don't need to fill in
         the fields)
4. Find or create a basket for the same vendor that's on the EDI account
5. Add an order to the basket from any source
6. In the menu bar at the top of the basket screen, click "Create
   EDIFACT order" and select an EAN
--> Note that the confirmation page doesn't tell you which EAN was
    selected
7. Click "No, don't close"
8. Apply patch and restart_all
9. Repeat step 6
--> The confirmation page should now display both the basket and the
    selected EAN
10. Click "Cancel"
--> Confirm that the basket is still open
11. Repeat step 6
12. Click "Yes, generate order and close basket"
--> Confirm the basket is closed
13. Click "EDIFACT messages" in the sidebar menu
--> Confirm that you see a message with type ORDERS for that basket

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 Kyle M Hall (khall) 2025-07-01 16:13:32 UTC
Created attachment 183675 [details] [review]
Bug 39572: Improve EDIFACT order confirmation message

Add EAN account information to EDIFACT order confirmation message

To test:
1. Set EDIFACT system preference to Enable
2. Create at least 2 EANs, one with a description and one without a
   description
   i. Go to Acquisitions > Library EANs
   ii. Click "New EAN" and fill in the fields
3. Create an EDI account
   i. Go to Acquisitions > EDI accounts
   ii. Click "New account"
   iii. Click Submit (for testing purposes you don't need to fill in
         the fields)
4. Find or create a basket for the same vendor that's on the EDI account
5. Add an order to the basket from any source
6. In the menu bar at the top of the basket screen, click "Create
   EDIFACT order" and select an EAN
--> Note that the confirmation page doesn't tell you which EAN was
    selected
7. Click "No, don't close"
8. Apply patch and restart_all
9. Repeat step 6
--> The confirmation page should now display both the basket and the
    selected EAN
10. Click "Cancel"
--> Confirm that the basket is still open
11. Repeat step 6
12. Click "Yes, generate order and close basket"
--> Confirm the basket is closed
13. Click "EDIFACT messages" in the sidebar menu
--> Confirm that you see a message with type ORDERS for that basket

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Martin Renvoize (ashimema) 2025-07-08 16:18:01 UTC
(In reply to Jeremy Evans from comment #2)
> Ideally it should show by default the supplier who sent the original EDI
> quote for that basket into Koha. That would reduce the possibility of user
> error of sending the confirmed order to the wrong supplier. At the moment it
> shows the first supplier sorted alphabetically by default.

I think you're a little confused here Jeremy.  The EAN you're selecting here is actually the 'from' library EAN.. not the 'to' Vendor SAN.

We should perhaps understand your problem better and address it in another bug if that's OK..

I think this bug is an improvement as it stands using the basketconfirm functionality that already existed and adding a little more detail to it.
Comment 12 Martin Renvoize (ashimema) 2025-07-08 16:27:09 UTC
Created attachment 183873 [details] [review]
Bug 39572: Improve EDIFACT order confirmation message

Add EAN account information to EDIFACT order confirmation message
when the BasketConfirmations system preference is enabled.

To test:
1. Set EDIFACT system preference to Enable
2. Set BasketConfirmations system preference to Enable
3. Create at least 2 EANs, one with a description and one without a
   description
   i. Go to Acquisitions > Library EANs
   ii. Click "New EAN" and fill in the fields
4. Create an EDI account
   i. Go to Acquisitions > EDI accounts
   ii. Click "New account"
   iii. Click Submit (for testing purposes you don't need to fill in
         the fields)
5. Find or create a basket for the same vendor that's on the EDI account
6. Add an order to the basket from any source
7. In the menu bar at the top of the basket screen, click "Create
   EDIFACT order" and select an EAN
--> Note that the confirmation page doesn't tell you which EAN was
    selected
8. Click "No, don't close"
9. Apply patch and restart_all
10. Repeat step 7
--> The confirmation page should now display both the basket and the
    selected EAN
11. Click "Cancel"
--> Confirm that the basket is still open
12. Repeat step 7
13. Click "Yes, generate order and close basket"
--> Confirm the basket is closed
14. Click "EDIFACT messages" in the sidebar menu
--> Confirm that you see a message with type ORDERS for that basket

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 13 Lucas Gass (lukeg) 2025-07-11 21:29:21 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 14 Paul Derscheid 2025-07-24 08:20:01 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 15 Fridolin Somers 2025-07-31 13:50:15 UTC
Pushed to 24.11.x for 24.11.08