Summary: | 'Last patron' results should display preferred name | ||
---|---|---|---|
Product: | Koha | Reporter: | Kristi <kkrueger> |
Component: | Patrons | Assignee: | Andrew Fuerste-Henry <andrew> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew, e.betemps, gmcharlt, kkrueger, kyle.m.hall, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 39576: Show preferred_name for hiddenborrowername
Bug 39576: Show preferred_name for hiddenborrowername Bug 39576: Show preferred_name for hiddenborrowername |
Description
Kristi
2025-04-07 17:43:49 UTC
Created attachment 180717 [details] [review] Bug 39576: Show preferred_name for hiddenborrowername The last patron menu uses the value "hiddenborrowername." I've made that use preferred_name instead of firstname. When a patron's preferred_name is not manually set/edited, it automatically takes the value of firstname, so we don't need an IF in the template toolkit here. To test: 1 - have a patron with a preferred_name and one without 2 - get both patrons in the Last Patron dropdown, confirm they both show firstname 3 - apply patch, restart services, clear cache, reload page 4 - get your patrons in Last Patron again, confirm now one shows preferred name and the other firstname Created attachment 180982 [details] [review] Bug 39576: Show preferred_name for hiddenborrowername The last patron menu uses the value "hiddenborrowername." I've made that use preferred_name instead of firstname. When a patron's preferred_name is not manually set/edited, it automatically takes the value of firstname, so we don't need an IF in the template toolkit here. To test: 1 - have a patron with a preferred_name and one without 2 - get both patrons in the Last Patron dropdown, confirm they both show firstname 3 - apply patch, restart services, clear cache, reload page 4 - get your patrons in Last Patron again, confirm now one shows preferred name and the other firstname Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Thanks for signing off, Emmanuel. I am putting this in signed off status. Hi, you're welcome ! (the hardest thing was to find how displaying the last patron dropdown... thanks to the manual ^^) Manu. Created attachment 182281 [details] [review] Bug 39576: Show preferred_name for hiddenborrowername The last patron menu uses the value "hiddenborrowername." I've made that use preferred_name instead of firstname. When a patron's preferred_name is not manually set/edited, it automatically takes the value of firstname, so we don't need an IF in the template toolkit here. To test: 1 - have a patron with a preferred_name and one without 2 - get both patrons in the Last Patron dropdown, confirm they both show firstname 3 - apply patch, restart services, clear cache, reload page 4 - get your patrons in Last Patron again, confirm now one shows preferred name and the other firstname Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Pushed for 25.05! Well done everyone, thank you! |