Bug 39588

Summary: Bookings to collect report won't load when the search returns currently checked out bookings
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Lucas Gass (lukeg) <lucas>
Status: Pushed to stable --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: andrew, gmcharlt, kkrueger, kyle.m.hall, martin.renvoize, paul.derscheid
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.05
Circulation function:
Attachments: Bug 39588: Fix concatenation in bookings to collect
Bug 39588: Fix concatenation in bookings to collect
Bug 39588: Fix concatenation in bookings to collect
Bug 39588: Fix concatenation in bookings to collect

Description Lucas Gass (lukeg) 2025-04-08 22:21:00 UTC
To recreate:

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report 
5. The table never loads

Uncaught TypeError: _(...).$date is not a function
Comment 1 Lucas Gass (lukeg) 2025-04-08 22:21:39 UTC
Looks like we are trying to concatenate with Perl, not JavaScript :)
Comment 2 Lucas Gass (lukeg) 2025-04-08 22:23:28 UTC
Created attachment 180735 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!
Comment 3 Andrew Fuerste-Henry 2025-04-09 13:43:07 UTC
Created attachment 180742 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Comment 4 Andrew Fuerste-Henry 2025-04-09 13:44:10 UTC
This patch is small/clear enough that I went ahead and signed off for Lucas.
Comment 5 PTFS Europe Sandboxes 2025-04-23 20:35:55 UTC
Created attachment 181398 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: kristi <kkrueger@cuyahogalibrary.org>
Comment 6 Kristi 2025-04-23 20:36:05 UTC
I followed the plan and the report loaded. 

Also, for my own concern, the report loads when both holding library and pickup library are set to "Any."
Comment 7 Martin Renvoize (ashimema) 2025-05-09 14:32:29 UTC
Created attachment 182186 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 8 Martin Renvoize (ashimema) 2025-05-09 14:32:58 UTC
Oops, thanks for fixing my mistake Lucas!
Comment 9 Katrin Fischer 2025-05-12 16:32:27 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 10 Kristi 2025-05-14 13:16:50 UTC
Happy to see this one! Could it be a candidate for backport to 24.11?
Comment 11 Paul Derscheid 2025-05-22 18:25:03 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.05