To recreate: 1. Turn on bookings for an item or item type 2. Find an item and book it. 3. Check the same item out. 4. Go to Circulation > Bookings to collect and run the report 5. The table never loads Uncaught TypeError: _(...).$date is not a function
Looks like we are trying to concatenate with Perl, not JavaScript :)
Created attachment 180735 [details] [review] Bug 39588: Fix concatenation in bookings to collect 1. Turn on bookings for an item or item type 2. Find an item and book it. 3. Check the same item out. 4. Go to Circulation > Bookings to collect and run the report 5. The table never loads 6. APPLY PATCH 7. Try again, the bookings to collect report should load!
Created attachment 180742 [details] [review] Bug 39588: Fix concatenation in bookings to collect 1. Turn on bookings for an item or item type 2. Find an item and book it. 3. Check the same item out. 4. Go to Circulation > Bookings to collect and run the report 5. The table never loads 6. APPLY PATCH 7. Try again, the bookings to collect report should load! Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
This patch is small/clear enough that I went ahead and signed off for Lucas.
Created attachment 181398 [details] [review] Bug 39588: Fix concatenation in bookings to collect 1. Turn on bookings for an item or item type 2. Find an item and book it. 3. Check the same item out. 4. Go to Circulation > Bookings to collect and run the report 5. The table never loads 6. APPLY PATCH 7. Try again, the bookings to collect report should load! Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: kristi <kkrueger@cuyahogalibrary.org>
I followed the plan and the report loaded. Also, for my own concern, the report loads when both holding library and pickup library are set to "Any."
Created attachment 182186 [details] [review] Bug 39588: Fix concatenation in bookings to collect 1. Turn on bookings for an item or item type 2. Find an item and book it. 3. Check the same item out. 4. Go to Circulation > Bookings to collect and run the report 5. The table never loads 6. APPLY PATCH 7. Try again, the bookings to collect report should load! Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Oops, thanks for fixing my mistake Lucas!
Pushed for 25.05! Well done everyone, thank you!
Happy to see this one! Could it be a candidate for backport to 24.11?