Bug 39588 - Bookings to collect report won't load when the search returns currently checked out bookings
Summary: Bookings to collect report won't load when the search returns currently check...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: rel_24_11_candidate
Depends on:
Blocks:
 
Reported: 2025-04-08 22:21 UTC by Lucas Gass (lukeg)
Modified: 2025-05-14 13:40 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39588: Fix concatenation in bookings to collect (1.43 KB, patch)
2025-04-08 22:23 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39588: Fix concatenation in bookings to collect (1.49 KB, patch)
2025-04-09 13:43 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 39588: Fix concatenation in bookings to collect (1.54 KB, patch)
2025-04-23 20:35 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 39588: Fix concatenation in bookings to collect (1.62 KB, patch)
2025-05-09 14:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-04-08 22:21:00 UTC
To recreate:

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report 
5. The table never loads

Uncaught TypeError: _(...).$date is not a function
Comment 1 Lucas Gass (lukeg) 2025-04-08 22:21:39 UTC
Looks like we are trying to concatenate with Perl, not JavaScript :)
Comment 2 Lucas Gass (lukeg) 2025-04-08 22:23:28 UTC
Created attachment 180735 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!
Comment 3 Andrew Fuerste-Henry 2025-04-09 13:43:07 UTC
Created attachment 180742 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Comment 4 Andrew Fuerste-Henry 2025-04-09 13:44:10 UTC
This patch is small/clear enough that I went ahead and signed off for Lucas.
Comment 5 PTFS Europe Sandboxes 2025-04-23 20:35:55 UTC
Created attachment 181398 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: kristi <kkrueger@cuyahogalibrary.org>
Comment 6 Kristi 2025-04-23 20:36:05 UTC
I followed the plan and the report loaded. 

Also, for my own concern, the report loads when both holding library and pickup library are set to "Any."
Comment 7 Martin Renvoize (ashimema) 2025-05-09 14:32:29 UTC
Created attachment 182186 [details] [review]
Bug 39588: Fix concatenation in bookings to collect

1. Turn on bookings for an item or item type
2. Find an item and book it.
3. Check the same item out.
4. Go to Circulation > Bookings to collect and run the report
5. The table never loads
6. APPLY PATCH
7. Try again, the bookings to collect report should load!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 8 Martin Renvoize (ashimema) 2025-05-09 14:32:58 UTC
Oops, thanks for fixing my mistake Lucas!
Comment 9 Katrin Fischer 2025-05-12 16:32:27 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 10 Kristi 2025-05-14 13:16:50 UTC
Happy to see this one! Could it be a candidate for backport to 24.11?