Summary: | Inventory tool DataTable doesn't properly load | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Cataloging | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Pushed to stable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | baptiste.wojtkowski, fridolin.somers, m.de.rooy, paul.derscheid, rcoert, sam.sowanick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39953 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00,24.11.05
|
Circulation function: | |
Bug Depends on: | 36496 | ||
Bug Blocks: | |||
Attachments: |
Bug 39633: Use column names to get table settings
Bug 39633: Use column names to get table settings Bug 37784: (QA follow-up) Add few tables to Koha::Database::Columns Bug 39633: Use column names to get table settings |
Description
Lucas Gass (lukeg)
2025-04-14 20:14:07 UTC
Also, when setting the default sort order we check `compareinv2barcd`. It should check uploadedbarcodesflag because the column only shows when when there is the uploadedbarcodesflag template variable Created attachment 180939 [details] [review] Bug 39633: Use column names to get table settings 1. Cataloging > Inventory 2. Run the tool without uploaded barcodes 3. Table loads and you see all the DataTable controls ( Table settings, etc ) 4. Run the tool while uploading at least 1 barcode 5. No DataTable controls 6. APPLY PATCH 7. Try steps 1 -4 again, making sure everything now works. Created attachment 181131 [details] [review] Bug 39633: Use column names to get table settings 1. Cataloging > Inventory 2. Run the tool without uploaded barcodes 3. Table loads and you see all the DataTable controls ( Table settings, etc ) 4. Run the tool while uploading at least 1 barcode 5. No DataTable controls 6. APPLY PATCH 7. Try steps 1 -4 again, making sure everything now works. Signed-off-by: Sam <sam.sowanick@corvallisoregon.gov> Created attachment 181147 [details] [review] Bug 37784: (QA follow-up) Add few tables to Koha::Database::Columns This resolves exceptions like: Invalid table name accountlines at /usr/share/koha/C4/Reports/Guided.pm line 216. Test plan: Go to reports/dictionary.pl Try to add a new definition for Serials. Without this patch, you would crash (status 500). Run t/Koha/Database/Columns.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Marcel, can you please check on this bug? The second patch doesn't seem to belong to this bug and the first patch doesn't have your sign-off line? Created attachment 181252 [details] [review] Bug 39633: Use column names to get table settings 1. Cataloging > Inventory 2. Run the tool without uploaded barcodes 3. Table loads and you see all the DataTable controls ( Table settings, etc ) 4. Run the tool while uploading at least 1 barcode 5. No DataTable controls 6. APPLY PATCH 7. Try steps 1 -4 again, making sure everything now works. Signed-off-by: Sam <sam.sowanick@corvallisoregon.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Katrin Fischer from comment #5) > Marcel, can you please check on this bug? The second patch doesn't seem to > belong to this bug and the first patch doesn't have your sign-off line? Fixed. Thanks! Pushed for 25.05! Well done everyone, thank you! (In reply to Lucas Gass (lukeg) from comment #1) > Also, when setting the default sort order we check `compareinv2barcd`. It > should check uploadedbarcodesflag because the column only shows when when > there is the uploadedbarcodesflag template variable Hi, why changing the order number ? // sort on callnumber - "order": [[ 1, "asc" ]], + "order": [[ 2, "asc" ]], Looks like callnumber is still second column in this case. Code in the other case says : // 3rd column is callnumber "order": [[ 2, "asc" ]], Nice work everyone! Pushed to 24.11.x for 24.11.05 |